Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for EIP-1202 #1237

Merged
merged 14 commits into from
Jul 21, 2018
Merged

PR for EIP-1202 #1237

merged 14 commits into from
Jul 21, 2018

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Jul 19, 2018

Please see discussion in #1202. This is a re-submission of #1209

EIPS/eip-1202.md Outdated
---
eip: 1202
title: Voting Standard
author: Zainan Victor Zhou <zzn@zzn.im>, Evan(@evbots ) and open to have one more co-author
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only include author names in this field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

EIPS/eip-1202.md Outdated
---
eip: 1202
title: Voting Standard
author: Zainan Victor Zhou (@xinbenlv) <eip1202@zzn.im>, Evan(@evbots)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pick either email address or Github username, not both - the site can't parse both together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nick, thanks for the review. I updated the content with your suggestion, can you check if it look good now

@Arachnid Arachnid merged commit 0b3ca48 into ethereum:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants