Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EIP-1283 status to last call #1367

Merged
merged 4 commits into from
Oct 15, 2018
Merged

Move EIP-1283 status to last call #1367

merged 4 commits into from
Oct 15, 2018

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented Aug 31, 2018

The spec is finalized, covered with test cases, and had an informal proof. See discussion on ethereum/pm#55

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 1283 state from Draft to Accepted

@axic
Copy link
Member

axic commented Sep 20, 2018

@gumb0 @holiman @5chdn I am not sure what the process is regarding moving this from Draft to Accepted, but I think it is mostly down to the client implementers doing the hard fork changes.

@5chdn
Copy link
Contributor

5chdn commented Sep 21, 2018

It's accepted as decided in the constantinople session 1, see also meta eip, e.g., #1366

@axic
Copy link
Member

axic commented Sep 25, 2018

Actually it seems according to the EIP-1 this should go through a Last Call step first:

Accepted (Core EIPs only) -- A successful Last Call without material changes or unaddressed technical complaints will become Accepted.

@sorpaas sorpaas changed the title Move EIP-1283 status to accepted Move EIP-1283 status to last call Sep 26, 2018
@sorpaas
Copy link
Contributor Author

sorpaas commented Sep 26, 2018

@axic That looks like a new change in the EIP process after I made this PR -- I don't remember previously Core EIPs had "Last Call" status. (Edit: the change #1224 was earlier, my fault!)

Anyway, just changed!

@axic
Copy link
Member

axic commented Sep 27, 2018

@sorpaas also it seems that the Last Call would require an additional field: review-period-end:

Though perhaps for hard fork related EIPs the last call process is not enforced.

@Arachnid Arachnid merged commit 0235c94 into ethereum:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants