Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EIP-1283 status to Accepted #1565

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Move EIP-1283 status to Accepted #1565

merged 1 commit into from
Nov 26, 2018

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented Nov 8, 2018

The Last Call period to 10-29 has ended. So I think it might be fine to move this to Accepted.

All Changes

The entire set of changes are:

  • Minor grammar fixes.
  • Clarified in spec that while overall transaction refund counter cannot go negative, call-frame specific refund counter can go negative.
  • Added a formal proof!

All discussions

  • @fulldecent raised a question about whether this gas scheme can result in high memory usage because of storage cache. The conclusion is that an attacker (given its goal is to cause as high memory usage as possible) cannot allocate more memory via storage cache -- whenever we need storage cache allocation, the gas cost is the same as current gas scheme, and refund counter cannot be used in current transaction.
  • @fulldecent also raised some questions regarding the economics aspect of SSTORE. They may be better suited for storage rent discussions.

@fulldecent
Copy link
Contributor

Please include the full list of changes from entering the last until now.

@fulldecent
Copy link
Contributor

Please include an enumeration of all issues raised during last call and your review of the outcome. Do @ - mention relevant people.

For reference, please review this last call promotion: #1170

@sorpaas
Copy link
Contributor Author

sorpaas commented Nov 15, 2018

@fulldecent Thanks. Added!

@fulldecent
Copy link
Contributor

To be clear. My concern is not the economics or the gas costs. My concern is the absence of an analysis of economics and gas costs in the EIP.

@Arachnid Arachnid merged commit e6c3f29 into ethereum:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants