Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark EIP1014/EIP1052 as accepted (part of Constantinople) #1689

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Mark EIP1014/EIP1052 as accepted (part of Constantinople) #1689

merged 1 commit into from
Jan 22, 2019

Conversation

axic
Copy link
Member

@axic axic commented Jan 11, 2019

No description provided.

@axic
Copy link
Member Author

axic commented Jan 11, 2019

cc @vbuterin @chfast @Arachnid @Souptacular

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 1014 state from Draft to Accepted
  • Trying to change EIP 1052 state from Draft to Accepted
  • EIP 1014 requires approval from one of (@vbuterin)
  • EIP 1052 requires approval from one of (pawel@ethereum.org, @Arachnid)

@axic axic mentioned this pull request Jan 11, 2019
Closed
@bmann
Copy link
Contributor

bmann commented Jan 12, 2019

And please merge in #1642 please.

This was referenced Jan 15, 2019
Closed
Closed
5chdn
5chdn suggested changes Jan 21, 2019
View reviewed changes
EIPS/eip-1014.md
@@ -4,7 +4,7 @@ title: Skinny CREATE2
author: Vitalik Buterin (@vbuterin)
category: Core
type: Standards Track
status: Draft
status: Accepted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Final

EIPS/eip-1052.md
@@ -3,7 +3,7 @@ eip: 1052
title: EXTCODEHASH opcode
author: Nick Johnson <arachnid@notdot.net>, Paweł Bylica <pawel@ethereum.org>
discussions-to: https://ethereum-magicians.org/t/extcodehash-opcode/262
status: Draft
status: Accepted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Final

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #1642 supposed to set it to final, according to the "process" :)

@5chdn 5chdn mentioned this pull request Jan 21, 2019
Closed
@gcolvin gcolvin merged commit cddbb47 into ethereum:master Jan 22, 2019
@axic axic deleted the constantinople-accepted branch January 22, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5chdn 5chdn 5chdn requested changes

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@axic @eip-automerger @bmann @chfast @5chdn @gcolvin