Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Audience Review process to EIPs prior to Last Call #1725

Closed
wants to merge 7 commits into from
Closed

Add Audience Review process to EIPs prior to Last Call #1725

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
94e5d48
Add Review by suggested stakeholders
fubuloubu Jan 25, 2019
21738b6
'review-period-end' -> 'last-call-period-end'
fubuloubu Jan 25, 2019
c21537e
Merge branch 'master' into patch-1
fubuloubu May 30, 2019
f9001bb
Merge branch 'master' into patch-1
axic Sep 26, 2019
939f987
Update eip-1.md
axic Sep 28, 2019
032fb3d
Fix typo added in merge commit
axic Sep 28, 2019
2ee0188
Update eip-1.md
axic Dec 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions EIPS/eip-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,26 @@ These calls generally result in a "rough consensus" around what EIPs should be i
Following is the process that a successful non-Core EIP will move along:

```
[ WIP ] -> [ DRAFT ] -> [ LAST CALL ] -> [ FINAL ]
[ IDEA ] -> [ DRAFT ] -> [ REVIEW ] -> [ LAST CALL ] -> [ FINAL ]
```

Following is the process that a successful Core EIP will move along:

```
[ IDEA ] -> [ DRAFT ] -> [ LAST CALL ] -> [ ACCEPTED ] -> [ FINAL ]
[ IDEA ] -> [ DRAFT ] -> [ REVIEW ] -> [ LAST CALL ] -> [ ACCEPTED ] -> [ FINAL ]
```

Each status change is requested by the EIP author and reviewed by the EIP editors. Use a pull request to update the status. Please include a link to where people should continue discussing your EIP. The EIP editors will process these requests as per the conditions below.

* **Idea** -- Once the champion has asked the Ethereum community whether an idea has any chance of support, they will write a draft EIP as a [pull request]. Consider including an implementation if this will aid people in studying the EIP.
* :arrow_right: Draft -- If agreeable, EIP editor will assign the EIP a number (generally the issue or PR number related to the EIP) and merge your pull request. The EIP editor will not unreasonably deny an EIP.
* :x: Draft -- Reasons for denying draft status include being too unfocused, too broad, duplication of effort, being technically unsound, not providing proper motivation or addressing backwards compatibility, or not in keeping with the [Ethereum philosophy](https://github.com/ethereum/wiki/wiki/White-Paper#philosophy).
* **Draft** -- Once the first draft has been merged, you may submit follow-up pull requests with further changes to your draft until such point as you believe the EIP to be mature and ready to proceed to the next status. An EIP in draft status must be implemented to be considered for promotion to the next status (ignore this requirement for core EIPs).
* :arrow_right: Last Call -- If agreeable, the EIP editor will assign Last Call status and set a review end date (`review-period-end`), normally 14 days later.
* :x: Last Call -- A request for Last Call status will be denied if material changes are still expected to be made to the draft. We hope that EIPs only enter Last Call once, so as to avoid unnecessary noise on the RSS feed.
* **Draft** -- Once the first draft has been merged, you may submit follow-up pull requests with further changes to your draft until such point as you believe the EIP to be mature and ready to proceed to the next status. An EIP in draft status must be implemented to be considered for promotion to the next status (ignore this requirement for core EIPs). During this time period, any member may suggest that a stakeholder group be added to the Review cycle when Draft is complete.
* :arrow_right: Review -- If agreeable, the EIP editor will assign Review status and alert relevant stakeholders to solicit their comments prior to Last Call. The EIP editor shall record tentative dates and participation links for discussions by these groups. Ideally, reviews should be scheduled to occur within a month.
* :x: Review -- A request to move to Review status will be denied if material changes are still expected to be made to the draft. This is to avoid unnecessary reviews by key stakeholders.
* **Review** -- When the draft is considered mature, no further changes are allowed to the proposal and all relevant stakeholder groups added during the Draft period are contacted and solicited for feedback. An Editor or member of a stakeholder group can request additional stakeholder groups be added. Any stakeholder groups can choose to remove themselves from review if they deem their opinions to be unnecessary by reporting a decision of "no comment". The minutes of the discussion, and the consensus recommendations of the group shall be summarized if a response is provided.
* :arrow_right: Last Call -- If there are no technical issues raised with the proposal by the suggested stakeholder groups, the EIP editor will assign Last Call status and set a public review end date (`last-call-period-end`), normally 14 days later.
* :x: Draft -- A Review which results in material changes or substantial unaddressed technical complaints will cause the EIP to revert to Draft. We hope that EIPs only enter Last Call once, so as to avoid unnecessary noise on the RSS feed.
* **Last Call** -- This EIP will listed prominently on the https://eips.ethereum.org/ website (subscribe via RSS at [last-call.xml](/last-call.xml)).
* :x: -- A Last Call which results in material changes or substantial unaddressed technical complaints will cause the EIP to revert to Draft.
* :arrow_right: Accepted (Core EIPs only) -- A successful Last Call without material changes or unaddressed technical complaints will become Accepted.
Expand Down Expand Up @@ -137,9 +140,9 @@ Each EIP must begin with an [RFC 822](https://www.ietf.org/rfc/rfc822.txt) style

` * discussions-to:` *a url pointing to the official discussion thread*

` status:` *Draft | Last Call | Accepted | Final | Active | Abandoned | Rejected | Superseded*
` status:` *Draft | Review | Last Call | Accepted | Final | Active | Abandoned | Rejected | Superseded*

`* review-period-end:` *date review period ends*
`* last-call-period-end:` *date last call period ends*

` type:` *Standards Track | Informational | Meta*

Expand Down