Changed draft to ERC725v2 #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discussion is ongoing here ethereum#725
Closed
|
wow, I dont really understand this out merging! @jpitts whats the idea behind this? Can't then not everybody come and change every standard? |
|
It is a draft and you are the author. It is automerged in that case. When somebody else submits a change to your draft, you can approve it on github. It is then automerged. For changes in non-drafts an editor needs to step in. |
|
@frozeman Also, others can submit changes to your Draft and if you Approve it, the bot will also auto-merge it |
|
Alright, get it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion is ongoing here #725
This change, changes the proposal radically and modularises it a lot.
725v2 is now the core proxy account, that can have one owner, which itself can be a smart contract like #734 and in the
setDataa #780 or #735 can be referenced.This makes it super flexible and creates a manageable verifiable account.