Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to solidity 0.5.x #2107

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Update examples to solidity 0.5.x #2107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions EIPS/eip-1261.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ interface IERC1261 {/* is ERC173, ERC165 */
/// Contract can set a max number of attributes and throw if limit is reached.
/// @param _name Name of the attribute which is to be added.
/// @param values List of values of the specified attribute.
function addAttributeSet(bytes32 _name, bytes32[] values) external;
function addAttributeSet(bytes32 _name, bytes32[] calldata values) external;

/// @notice Modifies the attribute value of a specific attribute for a given `_to` address.
/// @dev Use appropriate checks for whether a user/admin can modify the data.
Expand All @@ -112,7 +112,7 @@ interface IERC1261 {/* is ERC173, ERC165 */
/// dev can also oraclize the request to assign membership later
/// @param _attributeIndexes the attribute data associated with the member.
/// This is an array which contains indexes of attributes.
function requestMembership(uint[] _attributeIndexes) external payable;
function requestMembership(uint[] calldata _attributeIndexes) external payable;

/// @notice User can forfeit his membership.
/// @dev Throws if the `msg.sender` already doesn't have the token.
Expand Down Expand Up @@ -146,7 +146,7 @@ interface IERC1261 {/* is ERC173, ERC165 */
/// @param _to The address to which the token is assigned.
/// @param _attributeIndexes The attribute data associated with the member.
/// This is an array which contains indexes of attributes.
function assignTo(address _to, uint[] _attributeIndexes) external;
function assignTo(address _to, uint[] calldata _attributeIndexes) external;

/// @notice Only Owner can revoke the membership.
/// @dev This removes the membership of the user.
Expand All @@ -168,7 +168,7 @@ interface IERC1261 {/* is ERC173, ERC165 */
/// @dev Returns the values of attributes as a bytes32 array.
/// @param _name Name of the attribute whose values are to be fetched
/// @return The values of attributes.
function getAttributeExhaustiveCollection(bytes32 _name) external view returns (bytes32[]);
function getAttributeExhaustiveCollection(bytes32 _name) external view returns (bytes32[] memory);

/// @notice Returns the list of all past and present members.
/// @dev Use this function along with isCurrentMember to find wasMemberOf() in Js.
Expand All @@ -190,7 +190,7 @@ interface IERC1261 {/* is ERC173, ERC165 */
/// Which has a single attributeValue for each attributeName in an array.
/// Use web3.toAscii(data[0]).replace(/\u0000/g, "") to convert to string in JS.
/// @return The names of attributes.
function getAttributeNames() external view returns (bytes32[]);
function getAttributeNames() external view returns (bytes32[] memory);

/// @notice Returns the attributes of `_to` address.
/// @dev Throws if `_to` is the zero address.
Expand All @@ -215,7 +215,7 @@ interface ERC173 /* is ERC165 */ {

/// @notice Get the address of the owner
/// @return The address of the owner.
function owner() view external;
function owner() external view;

/// @notice Set the address of the new owner of the contract
/// @param _newOwner The address of the new owner of the contract
Expand Down