Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP: Add DID related methods to the JSON-RPC #2844

Merged
merged 4 commits into from
Aug 1, 2020
Merged

EIP: Add DID related methods to the JSON-RPC #2844

merged 4 commits into from
Aug 1, 2020

Conversation

oed
Copy link
Contributor

@oed oed commented Aug 1, 2020 •
edited
Loading

Discussions to: #2845

@oed oed marked this pull request as ready for review August 1, 2020 10:04
MicahZoltu
MicahZoltu suggested changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the least this needs the EIP number set in the header and file name, but the rest of the comments are just feedback and not blockers for merging as a draft. The bot may be unhappy wit the spelling error though.

@oed
Copy link
Contributor Author

oed commented Aug 1, 2020

Thanks for your feedback @MicahZoltu! Updated the PR with the EIP number and addressed some of your comments.

@MicahZoltu MicahZoltu merged commit 7d09ab2 into ethereum:master Aug 1, 2020
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@oed @tkstanczak
EIP: Add DID related methods to the JSON-RPC (ethereum#2844)
15b82ac 
* EIP: Add DID related methods to the JSON-RPC

* chore: add discussions url

* chore: fix typos

* chore: update eip number, small editorial fixes

Co-authored-by: Joel Thorstensson <joel@oed.earth>
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
@oed @Arachnid
EIP: Add DID related methods to the JSON-RPC (ethereum#2844)
c5c0b73 
* EIP: Add DID related methods to the JSON-RPC

* chore: add discussions url

* chore: fix typos

* chore: update eip number, small editorial fixes

Co-authored-by: Joel Thorstensson <joel@oed.earth>
@imsys imsys mentioned this pull request Nov 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicahZoltu MicahZoltu MicahZoltu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oed @MicahZoltu