Account abstraction EIP #2938

vbuterin · 2020-09-04T05:32:04Z

Account abstraction (AA) allows a contract to be the top-level account that pays fees and starts transaction execution.

EIPS/eip-2938.md

Co-authored-by: Micah Zoltu <micah@zoltu.net>

MicahZoltu

Only the Abstract inclusion suggestion and the Specification section naming suggestion are required for merging as a draft. The rest is just generalized feedback that you can ignore until Last Call.

MicahZoltu · 2020-09-05T07:36:45Z

EIPS/eip-2938.md

+
+## Motivation


Suggested change

## Motivation

## Abstract

TBD

## Motivation

I believe the Abstract is a required section. For draft, it just needs to be present, not complete. I generally recommend it include ea human readable and very terse version of the specification (maybe a paragraph or two).

MicahZoltu · 2020-09-05T07:37:17Z

EIPS/eip-2938.md

+
+## Motivation
+
+**See also: https://ethereum-magicians.org/t/implementing-account-abstraction-as-part-of-eth1-x/4020 and the links therein for historical work and motivation.**


Suggested change

**See also: https://ethereum-magicians.org/t/implementing-account-abstraction-as-part-of-eth1-x/4020 and the links therein for historical work and motivation.**

This is already in the header, so putting it here is redundant. Recommend removing.

EIPS/eip-2938.md

MicahZoltu · 2020-09-05T08:11:04Z

EIPS/eip-2938.md

+
+## Security Considerations
+
+See https://ethresear.ch/t/dos-vectors-in-account-abstraction-aa-or-validation-generalization-a-case-study-in-geth/7937 for an analysis of DoS issues.


At some point before final security considerations should be inlined into this document, but that isn't necessary for draft status.

MicahZoltu · 2020-09-05T08:11:37Z

EIPS/eip-2938.md

+All AA contracts may also potentially not have replay protection, unless they build it in explicitly; this can be done with the `CHAINID (0x46)` opcode introduced in [EIP 1344](./eip-1344.md).
+
+## Test Cases
+See: https://github.com/quilt/tests/tree/account-abstraction


Ideally, test cases will be inlined into this document, or added as an asset to ../assets/eip-2938/whatever.wat, but that isn't necessary for draft status.

.wat, are you suggesting the introduction of WebAssembly? 🙊

holgerd77 · 2020-09-05T21:22:54Z

EIPS/eip-2938.md

+
+## Specification (Single-tenant AA)
+
+After `FORK_BLOCK`, the following changes will be recognized by the protocol.


This would be "Starting with FORK_BLOCK" I guess?

holgerd77 · 2020-09-05T21:27:25Z

EIPS/eip-2938.md

+
+### New Transaction Type
+
+A new EIP-2718 transaction with type `AA_TX_TYPE` is introduced. Transactions of this type are referred to as "AA transactions". Their payload should be interpreted as `rlp([nonce, target, data])`.


Can the "EIP-2718" mention be supplemented by the EIP title (in brackets) here for readability?

EIPS/eip-2938.md

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing

MicahZoltu

Missed one required change in my previous review.

EIPS/eip-2938.md

axic · 2020-09-10T23:24:58Z

EIPS/eip-2938.md

+
+#### `NONCE (0xAB)` Opcode
+
+A new opcode `NONCE (0xAB)` is introduced, with gas cost `G_base`, which pushes the `tx.nonce` onto the stack.


Suggestion:

Suggested change

A new opcode `NONCE (0xAB)` is introduced, with gas cost `G_base`, which pushes the `tx.nonce` onto the stack.

A new opcode `NONCE (0xAB)` is introduced, with gas cost `G_base`, which pushes the `account.nonce` onto the stack.

If tx.nonce would be used, I would suggest to name this TXNONCE. Luckily however tx.nonce == account.nonce, so changing the description is enough.

axic · 2020-09-10T23:27:06Z

EIPS/eip-2938.md

+
+A new opcode `NONCE (0xAB)` is introduced, with gas cost `G_base`, which pushes the `tx.nonce` onto the stack.
+
+#### `PAYGAS (0xAA)` Opcode


While I see it is clever to use 0xAA and 0xAB as opcodes, I think if this is adopted these opcodes should fit into appropriate sections: which is likely 0x48 and 0x49.

As a draft the current proposed ones are fine, perhaps I should leave this comment on the discussion url.

axic · 2020-09-10T23:27:48Z

EIPS/eip-2938.md

+
+#### `PAYGAS (0xAA)` Opcode
+
+A new opcode `PAYGAS (0xAA)` is introduced, with gas cost `G_base`. It takes two arguments off the stack: (top) `version_number`, (second from top) `memory_start`. In the initial implementation, it will `assert version_number == 0` and read:


Curious: why a version and what future versions are envisioned?

EIP 1559

Escalator

Block hash and block number dependencies

Co-authored-by: Micah Zoltu <micah@zoltu.net>

MicahZoltu

I recommend reviewing the feedback that has been left, but that can be applied after merging as draft.

Account abstraction (AA) allows a contract to be the top-level account that pays fees and starts transaction execution.

vbuterin added 4 commits September 4, 2020 13:31

Account abstraction EIP

81bab09

Account abstraction (AA) allows a contract to be the top-level account that pays fees and starts transaction execution.

Added link

9880f08

Added security link

657de1c

A few typos

f114437

villanuevawill mentioned this pull request Sep 4, 2020

Ethereum Core Devs Meeting 95 Agenda ethereum/pm#203

Closed

lightclient approved these changes Sep 4, 2020

View reviewed changes

MicahZoltu reviewed Sep 4, 2020

View reviewed changes

EIPS/eip-2938.md Outdated Show resolved Hide resolved

vbuterin and others added 2 commits September 4, 2020 16:56

Update EIPS/eip-2938.md

2537b2b

Co-authored-by: Micah Zoltu <micah@zoltu.net>

CHAINID-related modifications

7725d77

MicahZoltu suggested changes Sep 5, 2020

View reviewed changes

holgerd77 reviewed Sep 5, 2020

View reviewed changes

MicahZoltu reviewed Sep 6, 2020

View reviewed changes

EIPS/eip-2938.md Outdated Show resolved Hide resolved

axic added the type: Core label Sep 6, 2020

vbuterin and others added 3 commits September 10, 2020 09:11

Update EIPS/eip-2938.md

19a1765

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Update EIPS/eip-2938.md

fc0435f

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Automatically merged updates to draft EIP(s) 2938 (#2963)

b9040d2

Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing

MicahZoltu suggested changes Sep 10, 2020

View reviewed changes

EIPS/eip-2938.md Outdated Show resolved Hide resolved

axic reviewed Sep 10, 2020

View reviewed changes

vbuterin and others added 2 commits September 13, 2020 09:19

Update EIPS/eip-2938.md

1733141

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Added reference to IS_STATIC

296992f

MicahZoltu approved these changes Sep 13, 2020

View reviewed changes

MicahZoltu merged commit 3750af8 into master Sep 13, 2020

MicahZoltu deleted the vbuterin-patch-3 branch September 13, 2020 06:23

3esmit mentioned this pull request Sep 30, 2020

EIP: Coinbase Calls #2474

Merged

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020

Account abstraction EIP (ethereum#2938)

101f828

Account abstraction (AA) allows a contract to be the top-level account that pays fees and starts transaction execution.

Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021

Account abstraction EIP (ethereum#2938)

00ea9f9

Account abstraction (AA) allows a contract to be the top-level account that pays fees and starts transaction execution.

vbuterin mentioned this pull request Mar 10, 2021

Using flashbots as a backdoor path to account abstraction flashbots/pm#24

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Account abstraction EIP #2938

Account abstraction EIP #2938

vbuterin commented Sep 4, 2020

MicahZoltu left a comment

MicahZoltu Sep 5, 2020

MicahZoltu Sep 5, 2020

MicahZoltu Sep 5, 2020

MicahZoltu Sep 5, 2020

axic Sep 10, 2020

holgerd77 Sep 5, 2020

holgerd77 Sep 5, 2020

MicahZoltu left a comment

axic Sep 10, 2020 •

edited

Loading

axic Sep 10, 2020

axic Sep 10, 2020

vbuterin Sep 13, 2020 •

edited

Loading

MicahZoltu left a comment


		## Motivation

		See also: https://ethereum-magicians.org/t/implementing-account-abstraction-as-part-of-eth1-x/4020 and the links therein for historical work and motivation.


		## Security Considerations

		See https://ethresear.ch/t/dos-vectors-in-account-abstraction-aa-or-validation-generalization-a-case-study-in-geth/7937 for an analysis of DoS issues.


		## Specification (Single-tenant AA)

		After `FORK_BLOCK`, the following changes will be recognized by the protocol.


		### New Transaction Type

		A new EIP-2718 transaction with type `AA_TX_TYPE` is introduced. Transactions of this type are referred to as "AA transactions". Their payload should be interpreted as `rlp([nonce, target, data])`.


		#### `NONCE (0xAB)` Opcode

		A new opcode `NONCE (0xAB)` is introduced, with gas cost `G_base`, which pushes the `tx.nonce` onto the stack.


		A new opcode `NONCE (0xAB)` is introduced, with gas cost `G_base`, which pushes the `tx.nonce` onto the stack.

		#### `PAYGAS (0xAA)` Opcode


		#### `PAYGAS (0xAA)` Opcode

		A new opcode `PAYGAS (0xAA)` is introduced, with gas cost `G_base`. It takes two arguments off the stack: (top) `version_number`, (second from top) `memory_start`. In the initial implementation, it will `assert version_number == 0` and read:

Account abstraction EIP #2938

Account abstraction EIP #2938

Conversation

vbuterin commented Sep 4, 2020

MicahZoltu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MicahZoltu left a comment

Choose a reason for hiding this comment

axic Sep 10, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vbuterin Sep 13, 2020 • edited Loading

Choose a reason for hiding this comment

MicahZoltu left a comment

Choose a reason for hiding this comment

axic Sep 10, 2020 •

edited

Loading

vbuterin Sep 13, 2020 •

edited

Loading