Fix EIP Bot

[Pandapip1]

Will need a manual merge, and the following branch protection settings will need to be updated:

• Enable "Require Review from Code Owners"
• Enable "Dismiss Stale PR Reviews"
• Remove "Auto-Merge Bot / EIP Auto-Merge Bot" from required checks

Do these only AFTER this PR is merged.

NEEDS TESTING, BE READY TO REVERT THIS PR IF NEEDED This has been successfully E2E tested.

Here's how it works:

1. The original triggering event triggers the trigger workflow.
2. The trigger job runs, adding the PR Number as an artifact.
3. The trigger workflow completes, triggering the actual workflow.
4. EIP-Bot runs
5. If EIP-Bot passes, then auto-merge is enabled and @eth-bot submits an approval, passing the CODEOWNERS review.
6. Automerge merges the PR

[eth-bot]

A critical and unhandled exception has occurred:
Message: not found
Data: (there is no data for this error)(cc @alita-moore, @mryalamanchi)

[Pandapip1]

Unfortunately, it's hard to know if the changes will work or not in advance. I think they will, but it really is hard to know. They work https://github.com/Pandapip1/EIPs-clone/pull/1.

[SamWilsn]

Left a few comments, but I have no idea what's going on here 🤣

[MicahZoltu]

Unfortunately, it's hard to know if the changes will work or not in advance. I think they will, but it really is hard to know.

It can (and should) be tested against a fork of the EIPs repository. This is how alita did all of their testing before we merged bot changes previously.

Out of curiosity, does anyone know why we don't just rely on GitHub's built in automerge feature entirely? It requires all checks pass I believe, so as long there is a bot to check for appropriate approvals (fails other ise) it feels like that should be good enough?

[JEAlfonsoP]

Unfortunately, it's hard to know if the changes will work or not in advance. I think they will, but it really is hard to know.

It can (and should) be tested against a fork of the EIPs repository. This is how alita did (I do not want to said something different but when I contacted her, She suggested to run a yarn test (I presume manually) ) all of their testing before we merged bot changes previously.

There are some changes needed to be done in yours EIP fork: .github/workflows
We have managed to get the Bot (auto merge bot) running, still working in the test cases for the PRs.

Out of curiosity, does anyone know why we don't just rely on GitHub's built in automerge feature entirely? It requires all checks pass I believe, so as long there is a bot to check for appropriate approvals (fails other ise) it feels like that should be good enough?

I believe that automerge is not an option if You the Editors do not feel 100% comfortable with BOTs and/or Validators. Thats why I imaging there are so many open issues and, why we have been working to get an automatized working environment.

[JEAlfonsoP]

Unfortunately, it's hard to know if the changes will work or not in advance. I think they will, but it really is hard to know.

We can test it (or at least try to).

[Pandapip1]

Out of curiosity, does anyone know why we don't just rely on GitHub's built in automerge feature entirely? It requires all checks pass I believe, so as long there is a bot to check for appropriate approvals (fails other ise) it feels like that should be good enough?

That is exactly what we're doing right now.

[MicahZoltu]

This PR added me back as an editor. 😢

[lightclient]

Sorry about that