Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5298: Move to Review #6343

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Update EIP-5298: Move to Review #6343

merged 5 commits into from
Jan 20, 2023

Conversation

xinbenlv
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Jan 16, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 16, 2023 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-5298.md

classification
updateEIP
  • passed!

@Pandapip1 Pandapip1 changed the title Move EIP-5298 to Review Update EIP-5298: Move to Review Jan 18, 2023
Pandapip1
Pandapip1 suggested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specification does not specify which ens nodes are approved.

@xinbenlv
Copy link
Contributor Author

xinbenlv commented Jan 19, 2023 •
edited
Loading

The specification does not specify which ens nodes are approved.

Ok, I'll add "Any ensNode is allowed", does it clarify your question? @Pandapip1

Pandapip1
Pandapip1 reviewed Jan 20, 2023
View reviewed changes
EIPS/eip-5298.md Outdated Show resolved Hide resolved
Pandapip1
Pandapip1 reviewed Jan 20, 2023
View reviewed changes
EIPS/eip-5298.md Outdated Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) January 20, 2023 14:38
@eth-bot eth-bot merged commit db23d1d into ethereum:master Jan 20, 2023
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
@xinbenlv @Pandapip1 @iseriohn
Update EIP-5298: Move to Review (ethereum#6343)
f055534 
* Update eip-5298.md

* Update eip-5298.md

* Update eip-5298.md

* Update eip-5298.md

* Fix grammar

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinbenlv @eth-bot @Pandapip1