-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Add @abcoathup as ERC/Meta/Informational editor #6575
Conversation
File
|
If @abcoathup's intent is to only assign EIP numbers, I would rather we push for automation. Instead if @abcoathup wants to participate as a full editor, I'd recommend a trial period like we did for @xinbenlv. |
@abcoathup would you be interested in becoming a trial editor? |
@SamWilsn & @Pandapip1 🙏
I'd prefer number issuing be automated too 😄 and that authors could get an EIP/ERC PR merged with minimal intervention. Then EIP/ERC editors could focus on using their domain knowledge to best improve draft EIP/ERCs. I check the repo each week day (along with Eth Magician discussions), but realistically could give about 30 minutes a day to editing. Enough to help with quick wins to get PRs into shape for merging, e.g. number assignment, guidance on how to comply with the automation, typos etc, but not enough to get into too many weeds. I wouldn't be able to attend any meetings as the timing doesn't work with my timezone (Melbourne)
If what I can offer is suitable, then happy to do a trial period. |
Great! CC @SamWilsn @axic @lightclient @gcolvin |
What's our plan for bot-assigning numbers? |
WIP, but a prototype has been made. I'm waiting on a full review from sam. |
@abcoathup we'd be happy to have you at that level of commitment! I guess our informal process is to have you start reviewing/commenting on PRs in the same way as an editor, and after some time we can add you to the editors list. |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
I've mostly assigned EIP/ERC numbers and some minor suggestions to draft EIP/ERCs. Happy to stay in this role. |
Bump. |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Bump. CC @SamWilsn |
I'm still happy assigning EIP/ERC numbers (assigned 9 of the last 13 sequential numbers). |
Closing because of #6575 (comment). If you'd like to apply for editorship, @abcoathup, please open a new pull request (or get someone to re-open this one.) |
Context: https://github.com/ethereum-cat-herders/EIPIP/issues/217#issuecomment-1442665320