-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates EIP-5573: Reflect changes in CACAO and UCAN specs #6654
Conversation
* updates eip5573 to reflect changes in CACAO and UCAN specs * clearly define the meaning of lexicographic ordering * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * remove unnecessary comma * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * remove uri field from statement * update recap-uri example * clarify that recap uris go at the end of the resource list * clarify comparison to OIDC/OAuth2 * specify how recap objects can be combined * remove mention of namespace * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * better wording of recap purpose/niche * specify b64 without padding * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * consistent spelling * rename delegee -> Relying Party * update example recap uri * fix abstract wording a little bit * use reference for b64url link * fix references layout * apply markdown linter --------- Co-authored-by: Jacob <jacob.ward@spruceid.com> Co-authored-by: Samuel Gbafa <skgbafa@gmail.com>
All reviewers have approved. Auto merging... |
The commit 87326ad (as a parent of b5c2662) contains errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the walidator issues.
Head branch was pushed to by a user without write access
@Pandapip1 I believe walidator issues have been fixed. Please approve. |
Noting completion here, thanks @chunningham / @skgbafa ! |
) * updates eip5573 to reflect changes in CACAO and UCAN specs (ethereum#7) * updates eip5573 to reflect changes in CACAO and UCAN specs * clearly define the meaning of lexicographic ordering * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * remove unnecessary comma * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * remove uri field from statement * update recap-uri example * clarify that recap uris go at the end of the resource list * clarify comparison to OIDC/OAuth2 * specify how recap objects can be combined * remove mention of namespace * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * better wording of recap purpose/niche * specify b64 without padding * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * consistent spelling * rename delegee -> Relying Party * update example recap uri * fix abstract wording a little bit * use reference for b64url link * fix references layout * apply markdown linter --------- Co-authored-by: Jacob <jacob.ward@spruceid.com> Co-authored-by: Samuel Gbafa <skgbafa@gmail.com> * change EIP to ERC, remove non-relative link (ethereum#8) --------- Co-authored-by: chunningham <c.a.cunningham6@gmail.com> Co-authored-by: Jacob <jacob.ward@spruceid.com>
) * updates eip5573 to reflect changes in CACAO and UCAN specs (#7) * updates eip5573 to reflect changes in CACAO and UCAN specs * clearly define the meaning of lexicographic ordering * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * remove unnecessary comma * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * remove uri field from statement * update recap-uri example * clarify that recap uris go at the end of the resource list * clarify comparison to OIDC/OAuth2 * specify how recap objects can be combined * remove mention of namespace * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * better wording of recap purpose/niche * specify b64 without padding * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * Update EIPS/eip-5573.md Co-authored-by: Jacob <jacob.ward@spruceid.com> * consistent spelling * rename delegee -> Relying Party * update example recap uri * fix abstract wording a little bit * use reference for b64url link * fix references layout * apply markdown linter --------- Co-authored-by: Jacob <jacob.ward@spruceid.com> Co-authored-by: Samuel Gbafa <skgbafa@gmail.com> * change EIP to ERC, remove non-relative link (#8) --------- Co-authored-by: chunningham <c.a.cunningham6@gmail.com> Co-authored-by: Jacob <jacob.ward@spruceid.com>
This PR updates EIP-5573 to enable easier integration with CACAO and UCAN by:
tar
andext
fields withatt
andprf
att
containing URIs as keys and objects as values<namespace>/<name>
ability strings as keys and an array of note-bene/restriction objects as values.+*-_
prf
containing an array of CIDs representing prior authorisationsrecap-object
to have lexicographically ordered keysrecap-uri
per SIWE message that must appear as the final entry in the resource listrecap-uri
By matching the
recap-object
to theatt
andprf
structure of ucan/cacao, interoperability between them becomes possible by treating a SIWE-recap as just one way of representing the same information, for signature verification purposes.