Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Collision of Contract Address Causes Exceptional Halt #689

Merged
merged 5 commits into from
Apr 5, 2018
Merged

Address Collision of Contract Address Causes Exceptional Halt #689

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd1949a
Add an EIP about making contract creation fail on address collision
pirapira Aug 7, 2017
a8253ad
Use 689
pirapira Dec 4, 2017
7ea0415
Adjust formats
pirapira Apr 4, 2018
7e0dedc
Cleanups by @Arachnid
pirapira Apr 5, 2018
762d03f
Merge branch 'master' into address-collision
Arachnid Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions EIPS/eip-689.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
---
eip: 689
title: Address Collision of Contract Address Causes Exceptional Halt
author: Yoichi Hirai <i@yoichihirai.com>
type: Standard Track
category: Core
status: Draft
created: 2017-08-15
---

## Simple Summary

This EIP proposes to make contract creation fail on an account with nonempty code or non-zero nonce.

## Abstract

Some test cases in the consensus test suite try to deploy a contract at an address already with nonempty code. Although such cases can virtually never happen on the main network before the Constantinople fork block, the test cases detected discrepancies in clients' behavior. Currently, the Yellow Paper says that the contract creation starts with the empty code and the initial nonce even in the case of address collisions. To simplify the semantics, this EIP proposes that address collisions cause failures of contract creation.

## Motivation

This EIP has no practical relevance to the main net history, but simplifies testing and reasoning.

This EIP has no effects after Constantinople fork because [EIP-86](https://github.com/ethereum/EIPs/pull/208) contains the changes proposed in this EIP. Even before the Constantinople fork, this EIP has no practical relevance because the change is visible only in case of a hash collision of keccak256.

Regarding testing, this EIP relieves clients from supporting reversion of code overwriting.

Regarding reasoning, this EIP establishes an invariant that non-empty code is never modified.

## Specification

If `block.number >= 0`, when a contract creation is on an account with non-zero nonce or non-empty code, the creation fails as if init code execution resulted in an exceptional halt. This applies to contract creation triggered by a contract creation transaction and by CREATE instruction.

## Rationale

It seems impractical to implement never-used features just for passing tests. Client implementations will be simpler with this EIP.

## Backwards Compatibility

This EIP is backwards compatible on the main network.

## Test Cases

At least the BlockchainTest called `createJS\_ExampleContract\_d0g0v0\_EIP158` will distinguish clients that implement this EIP.

## Implementation

## Copyright
Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).