Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Minimal Multi-Token Interface #6909

Merged
merged 16 commits into from
Jun 2, 2023
Merged

Add EIP: Minimal Multi-Token Interface #6909

merged 16 commits into from
Jun 2, 2023

Conversation

jtriley-eth
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Apr 19, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 19, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add Multi-Token Standard Add EIP: Multi-Token Standard Apr 19, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 19, 2023
@jtriley-eth jtriley-eth marked this pull request as ready for review April 19, 2023 17:47
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 19, 2023
@eth-bot eth-bot changed the title Add EIP: Multi-Token Standard Add EIP: Multi-Token Apr 19, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Apr 19, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 19, 2023
@github-actions
Copy link

The commit c9292dc (as a parent of 7fcc789) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 19, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 20, 2023
EIPS/eip-6909.md Outdated
@@ -0,0 +1,600 @@
---
eip: 6909
title: Multi-Token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to expand the title a bit. Multi-token doesn't give the reader enough information about the proposal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expanded to "Minimal Multi-Token Interface"

EIPS/eip-6909.md Outdated Show resolved Hide resolved
EIPS/eip-6909.md Outdated Show resolved Hide resolved
EIPS/eip-6909.md Outdated Show resolved Hide resolved
EIPS/eip-6909.md Outdated Show resolved Hide resolved
jtriley-eth and others added 3 commits May 30, 2023 10:12
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@eth-bot eth-bot changed the title Add EIP: Multi-Token Add EIP: Minimal Multi-Token Interface May 30, 2023
@eth-bot eth-bot enabled auto-merge (squash) June 2, 2023 05:10
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 444313b into ethereum:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants