Add EIP: Asset-bound Non-Fungible Tokens #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
|
✅ All reviewers have approved. |
eth-bot
changed the title
eth-bot
added
a-review
github-actions
bot
added
w-ci
tbergmueller
force-pushed
the
assetBoundNFT
branch
2 times, most recently
from
dba8455
to
e347538
Compare
github-actions
bot
added
w-ci
tbergmueller
force-pushed
the
assetBoundNFT
branch
5 times, most recently
from
17300e4
to
c34e06a
Compare
github-actions
bot
added
w-ci
tbergmueller
force-pushed
the
assetBoundNFT
branch
from
c34e06a
to
caa13e3
Compare
abcoathup
reviewed
Apr 30, 2023
tbergmueller
force-pushed
the
assetBoundNFT
branch
2 times, most recently
from
9c78698
to
3f45d9e
Compare
tbergmueller
force-pushed
the
assetBoundNFT
branch
2 times, most recently
from
a627228
to
4ce497d
Compare
SamWilsn
reviewed
May 18, 2023
tbergmueller
force-pushed
the
assetBoundNFT
branch
from
1713073
to
edf0bf5
Compare
ghost
previously approved these changes
May 18, 2023
5 tasks
|
Following discussion in Discord / #eip-editors, added in 8301954 the following SPDX-Identifier to interfaces in the EIP: This makes it abundantly clear that no patent- or license claims whatsoever can arise when implementing IERC6956* |
SamWilsn
reviewed
May 20, 2023
SamWilsn
previously approved these changes
May 20, 2023
- Changes IERC6956Floatable interface - Resolves TODO from reference implementation - Makes canFloat mechanics obsolete - removed
Using AccessControl when inheriting from multiple base contracts is likely to fail or result in very complex overriding structures. Replace it by a simple maintainers() mapping, isMaintainer() function (which can or shall be overridden) and maintainerOnly() modifier. Typically, isMaintainer() would be overriden by a derived contract and employ something like AccessControl.hasRole(MAINTAINER_ROLE)
- Interfaces streamlined and unified naming - Added Rationale and Security Considerations Resolve Review in EIP Editing Office Hour Meeting 17 - Maintainer-called functions removed from interfaces - Shortened abstract (250 words to 199 words) - Expanded abbreviations - Removed build files (hardhat, solhint), kept package.json Reference implementation - Resolved reentrant-attack vector for transferAnchor and burn - Minor gas optimizations
Also remove package.json
As discussed in #eip-editors, to clarify the interface is licensed under CC0-1.0 (as the EIP) but also under MIT. MIT ensures that any implementation of the interface is guaranteed to be free of eventual patent- and license claims.
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
tbergmueller
force-pushed
the
assetBoundNFT
branch
from
816f1cd
to
09adbac
Compare
To hopefully resolve auto-review bot's parsing issues See ethereum/eip-review-bot#270
eth-bot
added
e-review
SamWilsn
approved these changes
May 20, 2023
eth-bot
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial Draft of ASSET-BOUND NON-FUNGIBLE TOKENS
EIPS/eip-asset_bound_non_fungible_tokens.mdassets/eip-asset_bound_non_fungible_tokens