Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Elected block proposer has not been slashed #6988

Merged
merged 5 commits into from
May 30, 2023
Merged

Add EIP: Elected block proposer has not been slashed #6988

merged 5 commits into from
May 30, 2023

Conversation

mkalinin
Copy link
Contributor

@mkalinin mkalinin commented May 4, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels May 4, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 4, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title [WIP] EIP-6987: Slashed validator cannot be elected as a block proposer Add EIP: Slashed validator cannot be elected as a block proposer May 4, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels May 4, 2023
@mkalinin mkalinin mentioned this pull request May 4, 2023
Closed
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 4, 2023
abcoathup
abcoathup reviewed May 5, 2023
View reviewed changes
EIPS/eip-6987.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed May 5, 2023
View reviewed changes
EIPS/eip-6987.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed May 5, 2023
View reviewed changes
EIPS/eip-6987.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed May 5, 2023
View reviewed changes
EIPS/eip-6987.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed May 5, 2023
View reviewed changes
EIPS/eip-6987.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed May 5, 2023
View reviewed changes
EIPS/eip-6987.md Outdated Show resolved Hide resolved
g11tech
g11tech reviewed May 5, 2023
View reviewed changes
EIPS/eip-6987.md Outdated Show resolved Hide resolved
@mkalinin mkalinin dismissed a stale review via 7cbb4af May 17, 2023 12:25
mkalinin and others added 2 commits May 17, 2023 18:25
@mkalinin @abcoathup @g11tech
Apply suggestions from code review
7cbb4af 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: g11tech <develop@g11tech.io>
@mkalinin @abcoathup
Update EIPS/eip-6987.md
6518722 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 17, 2023
@mkalinin mkalinin mentioned this pull request May 18, 2023
Open
@eth-bot eth-bot changed the title Add EIP: Slashed validator cannot be elected as a block proposer Add EIP: Elected block proposer is not slashed May 19, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 19, 2023
@github-actions
Copy link

The commit 5672cd9 (as a parent of 2cb9ba1) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 19, 2023
@eth-bot eth-bot changed the title Add EIP: Elected block proposer is not slashed Add EIP: Elected block proposer has not been slashed May 19, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 19, 2023
@mkalinin mkalinin marked this pull request as ready for review May 19, 2023 06:57
@mkalinin mkalinin requested a review from eth-bot as a code owner May 19, 2023 06:57
@poojaranjan poojaranjan mentioned this pull request May 30, 2023
Closed
23 tasks
g11tech
g11tech approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eth-bot eth-bot enabled auto-merge (squash) May 30, 2023 15:01
eth-bot
eth-bot approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit b02ec2a into ethereum:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@eth-bot eth-bot eth-bot approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkalinin @eth-bot @abcoathup @g11tech