Update EIP-6953: Move to Review #7073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Beiko <t.beiko23@gmail.com>
github-actions
bot
added
c-status
|
✅ All reviewers have approved. |
eth-bot
changed the title
timbeiko
commented
May 25, 2023
| status: Draft | ||
| type: Informational | ||
| status: Review | ||
| type: Meta | ||
| created: 2023-04-28 | ||
| requires: 2982, 3675, 6122 |
There was a problem hiding this comment.
@MariusVanDerWijden can you move 6122 to Review ? thank you!
|
The commit 01d5ec1 (as a parent of 8fbf2c4) contains errors. |
23 tasks
SamWilsn
reviewed
May 30, 2023
EIPS/eip-6953.md
Outdated
| status: Draft | ||
| type: Informational | ||
| status: Review | ||
| type: Meta |
There was a problem hiding this comment.
I thought we had settled on Informational for this?
There was a problem hiding this comment.
haaa, I wasn't sure where we'd landed. happy to leave it as informational if you think it's best @SamWilsn
There was a problem hiding this comment.
@SamWilsn fixed - should be ready to merge now :-)
SamWilsn
approved these changes
Jun 2, 2023
eth-bot
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6991, based on the comments from @xinbenlv @SamWilsn and @g11tech in https://github.com/ethereum-cat-herders/EIPIP/issues/232.