Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-223: Update eip-223.md #7466

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Update EIP-223: Update eip-223.md #7466

merged 1 commit into from
Aug 9, 2023

Conversation

Dexaran
Copy link
Contributor

@Dexaran Dexaran commented Aug 9, 2023

Correct spelling.

Replace bytes32 symbol type with string because it must be string.

Add standard function to the ERC-223 standard description because it was removed as per this comment #6485 (comment)

This must be noted that "Interface introspection" and "Standard recognition" are two different tasks and therefore EIP-165 is not applicable to standard recognition.

interface HybridToken {
    function transfer(address to, uint256 value) external returns (bool);
    function approve(address spender, uint256 value) external returns (bool);
    function transferFrom(address from, address to, uint256 value) external returns (bool);
}

For example this hybrid token can utilize ERC-20 transferring patterns or ERC-223 transferring patterns depending on how it's transfer function is implemented.

Also, this is not a new method of introspection that I'm planning to introduce so there is no reason to submit it as a new EIP. This is just a method of identifying whether a token implements ERC-223 compatible transfer function or not for UIs.

@Dexaran Dexaran requested a review from eth-bot as a code owner August 9, 2023 13:57
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-erc labels Aug 9, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 9, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update eip-223.md Update EIP-223: Update eip-223.md Aug 9, 2023
@eth-bot eth-bot enabled auto-merge (squash) August 9, 2023 13:58
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ff3ec32 into ethereum:master Aug 9, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants