Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: Remove requires header #7478

Closed
wants to merge 2 commits into from
Closed

Update EIP-1: Remove requires header #7478

wants to merge 2 commits into from

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Aug 11, 2023

Removes the requires header in favor of it being automatically parsed from the links.

@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Aug 11, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 11, 2023

File EIPS/eip-1.md

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Aug 11, 2023
@Pandapip1 Pandapip1 linked an issue Aug 11, 2023 that may be closed by this pull request
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about dropping the requires header entirely, treating all links as normative, and generating a machine readable bibliography while rendering from the markdown representations we allow?

EIPS/eip-1.md Outdated Show resolved Hide resolved
@Pandapip1
Copy link
Member Author

How would you feel about dropping the requires header entirely, treating all links as normative, and generating a machine readable bibliography while rendering from the markdown representations we allow?

So basically remove the requires header and automatically cite all references?

@SamWilsn
Copy link
Contributor

So basically remove the requires header and automatically cite all references?

Yes, exactly. Parse the shorthands defined in EIP-1 from the proposal being rendered and generate a true bibliography.

@Pandapip1 Pandapip1 changed the title Update EIP-1: Full bibliography Update EIP-1: Remove requires header Aug 18, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me! I'll put it on the agenda for next EIPIP.

@SamWilsn SamWilsn mentioned this pull request Aug 21, 2023
12 tasks
@SamWilsn
Copy link
Contributor

From @xinbenlv, roughly:

Generating the bibliography isn't blocked on removing the requires: header, and there isn't enough justification to remove the header at this time.

@Pandapip1
Copy link
Member Author

Would there be any justification from keeping the header? I would be okay with grandfathering old EIPs.

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 18, 2023
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Jan 30, 2024
Copy link

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just hope this finally be resolved

Copy link

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace requires with a bibliography
4 participants