Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP: Token Exchange Standard for ERC20 tokens #823

Merged
merged 9 commits into from
Apr 29, 2018

Conversation

kashishkhullar
Copy link
Contributor

This EIP proposes a way to exchange tokens. This mechanism can also be used a situation where we need to spend tokens in different type. After a successful exchange the tokens given away are stored in the contract of the received token (which can be later used) .This scenario is similar to exchanging an apple for a orange. But both orange and apple have different value so we can get more oranges for one apple.

@Arachnid
Copy link
Contributor

This is a courtesy notice to let you know that the format for EIPs has been modified slightly. If you want your draft merged, you will need to make some small changes to how your EIP is formatted:

  • Frontmatter is now contained between lines with only a triple dash ('---')
  • Headers in the frontmatter are now lowercase.

If your PR is editing an existing EIP rather than creating a new one, this has already been done for you, and you need only rebase your PR.

In addition, a continuous build has been setup, which will check your PR against the rules for EIP formatting automatically once you update your PR. This build ensures all required headers are present, as well as performing a number of other checks.

Please rebase your PR against the latest master, and edit your PR to use the above format for frontmatter. For convenience, here's a sample header you can copy and adapt:

---
eip: <num>
title: <title>
author: <author>
type: [Standards Track|Informational|Meta]
category: [Core|Networking|Interface|ERC] (for type: Standards Track only)
status: Draft
created: <date>
---

I have removed the editor-needs-to-review label from your PR. Once you have updated your PR by following the instructions above, the build is passing, and you believe your EIP is ready to be merged as a draft (eg, outstanding technical issues are addressed), please readd that label and an editor will review it for merge.

@@ -0,0 +1,215 @@
## Preamble
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.

@@ -0,0 +1,215 @@
## Preamble
---
eip: <to be assigned>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please number this 823, and rename to eip-823.md.

@@ -0,0 +1,215 @@
## Preamble
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines in the header should not be indented.

eip: <to be assigned>
title: Token Exchange Standard
author: Kashish Khullar <kkhullar7@gmail.xcom>
type: Standard Track
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 'Standards Track'.

type: Standard Track
category: ERC
Status: Draft
sreated: 2018-01-06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'created'

author: Kashish Khullar <kkhullar7@gmail.xcom>
type: Standard Track
category: ERC
Status: Draft
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Status' should be lowercase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing @Arachnid .

@Arachnid Arachnid merged commit 711cb59 into ethereum:master Apr 29, 2018
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request May 2, 2018
* epi drafted

* minor changes made

* minor changes made

* changes to sender interface and added diagrams

* added diagrams in the markdown

* updated the diagrams

* update the headers

* made changes suggested by @Arachnid
@Arachnid
Copy link
Contributor

Arachnid commented May 8, 2018

Apologies - this should not have been merged with the PNG files in the root. Please move them to their own directory as done with other EIPS, and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants