-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP: Token Exchange Standard for ERC20 tokens #823
Conversation
This is a courtesy notice to let you know that the format for EIPs has been modified slightly. If you want your draft merged, you will need to make some small changes to how your EIP is formatted:
If your PR is editing an existing EIP rather than creating a new one, this has already been done for you, and you need only rebase your PR. In addition, a continuous build has been setup, which will check your PR against the rules for EIP formatting automatically once you update your PR. This build ensures all required headers are present, as well as performing a number of other checks. Please rebase your PR against the latest master, and edit your PR to use the above format for frontmatter. For convenience, here's a sample header you can copy and adapt:
I have removed the editor-needs-to-review label from your PR. Once you have updated your PR by following the instructions above, the build is passing, and you believe your EIP is ready to be merged as a draft (eg, outstanding technical issues are addressed), please readd that label and an editor will review it for merge. |
@@ -0,0 +1,215 @@ | |||
## Preamble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line.
@@ -0,0 +1,215 @@ | |||
## Preamble | |||
--- | |||
eip: <to be assigned> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please number this 823, and rename to eip-823.md.
@@ -0,0 +1,215 @@ | |||
## Preamble | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines in the header should not be indented.
eip: <to be assigned> | ||
title: Token Exchange Standard | ||
author: Kashish Khullar <kkhullar7@gmail.xcom> | ||
type: Standard Track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 'Standards Track'.
type: Standard Track | ||
category: ERC | ||
Status: Draft | ||
sreated: 2018-01-06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'created'
author: Kashish Khullar <kkhullar7@gmail.xcom> | ||
type: Standard Track | ||
category: ERC | ||
Status: Draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Status' should be lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing @Arachnid .
* epi drafted * minor changes made * minor changes made * changes to sender interface and added diagrams * added diagrams in the markdown * updated the diagrams * update the headers * made changes suggested by @Arachnid
Apologies - this should not have been merged with the PNG files in the root. Please move them to their own directory as done with other EIPS, and resubmit. |
This EIP proposes a way to exchange tokens. This mechanism can also be used a situation where we need to spend tokens in different type. After a successful exchange the tokens given away are stored in the contract of the received token (which can be later used) .This scenario is similar to exchanging an apple for a orange. But both orange and apple have different value so we can get more oranges for one apple.