Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-4762: unconditionnal account write during contract init #8867

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Update EIP-4762: unconditionnal account write during contract init #8867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions EIPS/eip-4762.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,6 @@ When a contract creation is initialized, process these write events:

```
(contract_address, 0, BASIC_DATA_LEAF_KEY)
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if "creation is initialized" is well defined. As in: after collision check.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking the same thing, also we should clarify the TouchAndChargeContractCreateCheck change that was done in geth. It is not obvious and may result in a few errors in implementation?


When a contract is created, process these write events:

```
(contract_address, 0, CODEHASH_LEAF_KEY)
```

Expand Down
Loading