-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Add Controlled Gas Limit Increase Strategy #8933
Conversation
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
In general I am not in favor of this approach. Because we currently have the freedom to let miners change the gas limit, this means that without a hardfork we can decide as community to scale up the gas limit. In case that a problem is found (for instance, a new DoS vector on blocks, like the Shanghai attacks https://ethos.dev/shanghai-attacks ) we can signal to miners that the gas limit should be scaled down (which can be done without a fork).
However, this EIP will remove this flexibility. If a problem is found and we need to decrease the gas limit as fast as possible, this means we have to fork, which will take a substantial amount of time.
As a general suggestion for this EIP: I would suggest linear increase of the gas limit, instead of an exponential increase. The exponential variant could lead to some rounding errors when rounding down to the nearest integer, which could lead to consensus bugs. The linear increase (constant gas limit bump per block) is also slightly easier to code.
validators are already voicing their concern with increased bandwidth requirements. Increasing gas to 60M will make the situation worse. Also, why would this be necessary with blob-based roadmap? Gas prices have been low since the last hardfork. #8931 seems like a better solution. |
#8931 does not do anything for bandwidth. there is an ongoing conversation about this. also this is a gradual increase so the gas limit is unlikely to reach 60mn - maybe 40-45mn. |
Can you re-comment on the updated version? |
So actually - the CL only sends it to the builder API and not to the engine api so this does not affect the EIP |
Co-authored-by: g11tech <develop@g11tech.io>
one job got cancelled :( |
i think it requires an approval from @SamWilsn or @lightclient to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and suggestions
Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Adds the possibility to have a gradual increase in gas target over time: