-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-7251: fix CONSOLIDATION_REQUEST_PREDEPLOY_ADDRES #9118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ All reviewers have approved. |
lightclient
approved these changes
Dec 9, 2024
eth-bot
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
12 tasks
jangko
added a commit
to status-im/nimbus-eth1
that referenced
this pull request
Dec 19, 2024
[Update EIP-7251: Set MAX_CONSOLIDATIONS=2](ethereum/EIPs#9127) will override [Update EIP-7251: fix CONSOLIDATION_REQUEST_PREDEPLOY_ADDRES](ethereum/EIPs#9118) therefore we only need the later.
tersec
pushed a commit
to status-im/nimbus-eth1
that referenced
this pull request
Dec 19, 2024
…2956) * devnet-5: fix Consolidation and Withdrawal request predeploy address [Update EIP-7251: Set MAX_CONSOLIDATIONS=2](ethereum/EIPs#9127) will override [Update EIP-7251: fix CONSOLIDATION_REQUEST_PREDEPLOY_ADDRES](ethereum/EIPs#9118) therefore we only need the later. * Fix test vectors
somnathb1
added a commit
to erigontech/erigon
that referenced
this pull request
Jan 11, 2025
See ethereum/EIPs#9119 and ethereum/EIPs#9118 Issue board: #12401
somnathb1
added a commit
to erigontech/erigon
that referenced
this pull request
Jan 13, 2025
See ethereum/EIPs#9119 and ethereum/EIPs#9118 Issue board: #12401
somnathb1
added a commit
to erigontech/erigon
that referenced
this pull request
Jan 13, 2025
See ethereum/EIPs#9119 and ethereum/EIPs#9118 Issue board: #12401 Cherry pick #13069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the address.
Verified with: https://gist.github.com/protolambda/58f73421b91602a6a0f5104a9f0f5c89
The
CONSOLIDATION_REQUEST_PREDEPLOY_ADDRESS
now matches the address in the bytecode deployment section again.