Update ERC-7007: Move to Review #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update erc-7007.md to add opML compatibility * Update erc-7007.md param name * Create IOpmlLib.sol * Update and rename ERC7007.sol to ERC7007_zkml.sol * Update IOpmlLib.sol * Update IOpmlLib.sol * Update IOpmlLib.sol * Create ERC7007_opml.sol * Update ERC7007_opml.sol * Update IOpmlLib.sol
* misc: improve abstract & motivation * fix: Spec intro & Model Publication wording * fix: Rewrite part of motivation * corrected some small typos * rewrote the last two paragraphs in Motivation --------- Co-authored-by: drCathieSo.eth <socathie@users.noreply.github.com>
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
eip-review-bot
changed the title
eip-review-bot
changed the title
* Update erc-7007.md: Fix wordings * update license * Update description and motivation -> rationale --------- Co-authored-by: drCathieSo.eth <socathie@users.noreply.github.com>
* Add workflow diagram * Add workflow description
eip-review-bot
changed the title
16 tasks
SamWilsn
reviewed
Feb 20, 2024
eip-review-bot
changed the title
tina1998612
approved these changes
Feb 20, 2024
tina1998612
approved these changes
Feb 20, 2024
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
|
The commit 45fb7bf (as a parent of 46c3cea) contains errors. |
14 tasks
SamWilsn
approved these changes
Mar 5, 2024
eip-review-bot
approved these changes
Mar 5, 2024
eip-review-bot
approved these changes
Mar 5, 2024
|
This was air-dropped in my Coinbase wallet during onchainsummer 2023 as an ERC-20 token in the gnosis network. The status of the token or nft at the time was undeveloped. It couldn't negotiate its own value to transfer, and it couldn't be minted. I tried reaching out to base (the host of onchainsummer), and they ignored me. Coinbase, finally after 13 months, took the wallets down. I believe it was fraudulent to. It was booby trapped on other coding apps. I was told to put it on hold, I never heard anything about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have updated our interface to support both validity (zkML) and fraud (opML) proofs. Added Rationale section. Also incorporated comments from Ethereum Magicians into Security Considerations.