Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-5564: Move to Last Call #322

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

garyghayrat
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 14, 2024

✅ All reviewers have approved.

Copy link
Contributor

@nerolation nerolation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments I can't place directly on the line:

Furthermore, the schemeId MUST be added to this overview

Once this proposal goes to final, that file will no longer be editable, so this requirement doesn't make sense.


This MUST be a singleton contract, with one instance per chain

You don't specify how the reader can find the singleton contract. One common approach is to use a universal deployer or "Nick's Method", but I am really not an expert on that kind of thing.

edit: ah, I see. I don't understand why this info is in the Backwards Compatibility section however.

The recipient's address and the viewTag MUST be included in the announcement event

The "MUST" here creates a requirement, but this sentence is not in the Specification section. If you're explaining a rule that already exists in that section, use the lowercase "must". If you do intend to create a new requirement, please move this to the Specification section.

ERCS/erc-5564.md Outdated Show resolved Hide resolved
ERCS/erc-5564.md Outdated Show resolved Hide resolved
ERCS/erc-5564.md Outdated Show resolved Hide resolved
ERCS/erc-5564.md Show resolved Hide resolved
@garyghayrat
Copy link
Contributor Author

A few comments I can't place directly on the line:

Furthermore, the schemeId MUST be added to this overview

Once this proposal goes to final, that file will no longer be editable, so this requirement doesn't make sense.

I've updated the ERC to only specify schemeId 1 in this ERC.

This MUST be a singleton contract, with one instance per chain

You don't specify how the reader can find the singleton contract. One common approach is to use a universal deployer or "Nick's Method", but I am really not an expert on that kind of thing.

edit: ah, I see. I don't understand why this info is in the Backwards Compatibility section however.

The Singleton contract address is in the Deployment Method section, but I've added another mention of the address right after the mention of the singleton contract.

The recipient's address and the viewTag MUST be included in the announcement event

The "MUST" here creates a requirement, but this sentence is not in the Specification section. If you're explaining a rule that already exists in that section, use the lowercase "must". If you do intend to create a new requirement, please move this to the Specification section.

I've added the viewTag requirement in the Specification section and updated to use lowercase "must" in the aforementioned sentence.

Copy link

github-actions bot commented Apr 4, 2024

The commit b1db74d (as a parent of 32d2221) contains errors.
Please inspect the Run Summary for details.

@eip-review-bot eip-review-bot enabled auto-merge (squash) April 16, 2024 14:37
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link

@moshahin01 moshahin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 2c07de2 into ethereum:master Apr 16, 2024
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants