-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-5564: Move to Last Call #322
Update ERC-5564: Move to Last Call #322
Conversation
✅ All reviewers have approved. |
9ccd1b3
to
ed8adae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments I can't place directly on the line:
Furthermore, the schemeId MUST be added to this overview
Once this proposal goes to final, that file will no longer be editable, so this requirement doesn't make sense.
This MUST be a singleton contract, with one instance per chain
You don't specify how the reader can find the singleton contract. One common approach is to use a universal deployer or "Nick's Method", but I am really not an expert on that kind of thing.
edit: ah, I see. I don't understand why this info is in the Backwards Compatibility section however.
The recipient's address and the
viewTag
MUST be included in the announcement event
The "MUST" here creates a requirement, but this sentence is not in the Specification section. If you're explaining a rule that already exists in that section, use the lowercase "must". If you do intend to create a new requirement, please move this to the Specification section.
caf9613
to
7e3e4e5
Compare
I've updated the ERC to only specify
The Singleton contract address is in the
I've added the |
The commit b1db74d (as a parent of 32d2221) contains errors. |
…erence Implementation` sections
b1db74d
to
a3bcb1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: