Add ERC: Soul Resonance Token #414
Conversation
eip-review-bot
changed the title
| @@ -0,0 +1,90 @@ | |||
| --- | |||
| eip: 7699 | |||
There was a problem hiding this comment.
| eip: 7699 | |
| eip: 7704 |
Assigning next sequential EIP/ERC/RIP number.
Please also update the filename.
|
|
||
| ## Abstract | ||
|
|
||
| This EIP proposes the following improvements to Soul Bond Tokens: |
There was a problem hiding this comment.
| This EIP proposes the following improvements to Soul Bond Tokens: | |
| This EIP proposes the following improvements to Soul Bound Tokens: |
Assume you mean bound?
| title: Soul Resonance Token | ||
| description: this EIP defines an interface for Soul Resonance Tokens | ||
| author: Mike Smith (@mike0x1024), Abe Johnson <abe@burve.io>, Alvis Kaiser <alvis@burve.io>, WurDst Tsao <wurst@burve.io> | ||
| discussions-to: https://ethereum-magicians.org/t/1 |
There was a problem hiding this comment.
Please create a topic in Ethereum Magicians with a link to this PR.
| --- | ||
| eip: 7699 | ||
| title: Soul Resonance Token | ||
| description: this EIP defines an interface for Soul Resonance Tokens |
There was a problem hiding this comment.
Your description just repeats your title. Try to expand on the idea you introduce there, instead of just restating it. Perhaps explain what a Soul Resonance Token is?
| This EIP proposes the following improvements to Soul Bond Tokens: | ||
| Extensibility to [ERC-20](./erc-20.md). | ||
| Token Minting and Burning while preserving non-transferability. |
There was a problem hiding this comment.
Your abstract should layout the goal of the proposal, and give the reader a high level technical overview of how it accomplishes that goal. Yours is probably a bit light on the technical side.
| Notes: | ||
| The contract is designed to be compiled with a Solidity compiler version greater than or equal to 0.8.20 but less than 0.9.0. |
There was a problem hiding this comment.
Generally standards should be applicable across all Solidity versions. You shouldn't need to note this.
| Notes: | |
| The contract is designed to be compiled with a Solidity compiler version greater than or equal to 0.8.20 but less than 0.9.0. |
| Notes: | ||
| The contract is designed to be compiled with a Solidity compiler version greater than or equal to 0.8.20 but less than 0.9.0. | ||
|
|
||
| The smart contract realising this EIP mandate must fully incorporate all methods prescribed by [ERC-20](./erc-20.md), with the exception of transfer operations. Furthermore, exclusivity to implementing solely this EIP is required. |
There was a problem hiding this comment.
This is vaguely worded. For example, if an implementer wants to support ERC-165, would this prevent them?
| ### Internal _update Function Override | ||
|
|
||
| ```solidity | ||
| function _update(address from, address to, uint256 value) internal virtual override { |
There was a problem hiding this comment.
_update is not part of the standard ERC-20. Are you thinking of OpenZeppelin perhaps?
EIPs should only specify the externally visible behaviours of contracts, and not their implementation specifics. _update looks like an internal function, and so should not be part of the standard.
|
|
||
| ```solidity | ||
| function mint(address to, uint256 amount) public { | ||
| _mint(to, amount); |
There was a problem hiding this comment.
Same comment here: _mint looks like an internal function.
|
|
||
| ```solidity | ||
| function burn(address from, uint256 amount) public { | ||
| _burn(from, amount); |
There was a problem hiding this comment.
And again here with _burn.
| ## Citation | ||
|
|
||
| Please cite this document as: | ||
| Burve Labs. "Bridging the Gap: Soul Resonance Token (SRT) Non-transferable yet Tradable Asset Type based on Bonding Curve"Burve Labs. 20 Apr. 2024. |
There was a problem hiding this comment.
| ## Citation | |
| Please cite this document as: | |
| Burve Labs. "Bridging the Gap: Soul Resonance Token (SRT) Non-transferable yet Tradable Asset Type based on Bonding Curve"Burve Labs. 20 Apr. 2024. |
The renderer will generate this section for you.
| ## References | ||
|
|
||
| **Implementations** | ||
|
|
||
| - [ERC-7699 Reference Implementation](https://github.com/mike0x1024/srt-template) | ||
|
|
There was a problem hiding this comment.
This is a non-standard section of EIPs. If you'd like to include a reference implementation, you may do so in the assets directory and link to it there.
sync new ERCs
|
The commit 6a7edd3 (as a parent of f50f283) contains errors. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: