Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect comment in EIP-3448 implementation #429

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

T1MOH593
Copy link
Contributor

This comment defines deploy code size:

  function _metaProxyFromMemory (address targetContract, uint256 offset, uint256 length) internal returns (address addr) {
    ...
@>    // The size is deploy code + contract code + calldatasize - 4 + 32.
      addr := create(0, start, sub(ptr, start))
    }
  }

Struggled some time to figure out what is calldata in this context. Eventually this comment was copied from previous function where it used the whole calldata except 4 bytes selector.

PR proposes right comment because length exactly defines metadata length.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented May 15, 2024

File ERCS/erc-3448.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

Copy link

@ShaheenRehman ShaheenRehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SamWilsn
Copy link
Collaborator

Would be ideal to get a review from @pinkiebell (as the author.)

@SamWilsn SamWilsn merged commit e3f5bbe into ethereum:master Aug 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants