-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Simple Permissions Checks #435
Open
hieronx
wants to merge
41
commits into
ethereum:master
Choose a base branch
from
hieronx:permissions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eip-review-bot
changed the title
Simple Permissions Check
Add ERC: Simple Permissions Checks
May 24, 2024
abcoathup
reviewed
May 24, 2024
abcoathup
reviewed
May 24, 2024
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
ERC7540: `requester` => `controller`
chore: add author
…ments comments
chore: some comments
fix: explanation on requestRedeem
The commit 6ff7a8a (as a parent of 07680c8) contains errors. |
This was referenced Jul 9, 2024
SamWilsn
reviewed
Jul 23, 2024
--- | ||
eip: 7714 | ||
title: Simple Permissions Checks | ||
description: Standardized interface for checking user permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your description could be a bit more detailed. What is a permission? What makes this proposal "simple"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: