Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Deterministic AA wallet #453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jaehunkim
Copy link

We propose a non-custodial interface for service providers to provide AA accounts.

@jaehunkim jaehunkim changed the title Add EIP: Deterministic AA wallet Add ERC: Deterministic AA wallet May 30, 2024
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented May 30, 2024

File ERCS/erc-TBA.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

ERCS/erc-TBA.md Outdated
@@ -0,0 +1,250 @@
---
eip: TBA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: TBA
eip: 7717

Assigning next sequential EIP/ERC/RIP number.

Please also update the filename.

Copy link

The commit 3bf9f17 (as a parent of 4b6ccba) contains errors.
Please inspect the Run Summary for details.

@@ -0,0 +1,250 @@
---
eip: 7717
title: Deterministic AA wallet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Deterministic AA wallet
title: Deterministic AA Wallet

---
eip: 7717
title: Deterministic AA wallet
description: Propose a non-custodial interface for service providers to provide AA accounts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Propose a non-custodial interface for service providers to provide AA accounts.
description: Non-custodial interface for service providers to provide AA accounts.

Cut out a bit of fluff, but I think you should expand on who "service providers" are, and what "provide" means in this context.


## Abstract

Propose a non-custodial interface for service providers to provide AA accounts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just your description again. Your abstract should contain enough detail to give the reader a high-level (but still technical) overview of how your proposal accomplishes its goal.

Comment on lines +20 to +23
- Problem
- The `createAccount` function necessitates an `owner` address to establish an account, consequently preventing service providers from creating accounts on behalf of their users without knowledge of the users’ EOA addresses. To resolve this limitation, service providers employ temporary EOAs to deterministically generate an [ERC-4337](./eip-4337.md) account for their users, assigning the temporary EOA as the initial owner. This approach, however, introduces a security vulnerability, as the temporary EOAs’ private keys are managed by the service providers. Furthermore, the service providers assume responsibility for these private keys until such a time when users take the ownership.
- Solution
- Set a separate contract as the owner when calling `createAccount`, and allow the user to claim ownership at a later date via a signature provided by the service provider.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivation section should be written (for the most part) in normal paragraph style.


## Reference Implementation

See `https://github.com/deterministic-aa/monorepo`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this external link. You may place a reference implementation inline (if it's CC0), or in the assets directory (if it's large or under another non-copyleft license.)


## Security Considerations

Needs discussion.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Needs discussion.
Needs discussion. <!-- TODO -->

If you use an HTML-style comment, the linter will make sure you replace it before advancing statuses.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a slight preference for SVGs, if you can provide them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants