-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Deterministic AA wallet #453
base: master
Are you sure you want to change the base?
Conversation
ERCS/erc-TBA.md
Outdated
@@ -0,0 +1,250 @@ | |||
--- | |||
eip: TBA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eip: TBA | |
eip: 7717 |
Assigning next sequential EIP/ERC/RIP number.
Please also update the filename.
The commit 3bf9f17 (as a parent of 4b6ccba) contains errors. |
@@ -0,0 +1,250 @@ | |||
--- | |||
eip: 7717 | |||
title: Deterministic AA wallet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Deterministic AA wallet | |
title: Deterministic AA Wallet |
--- | ||
eip: 7717 | ||
title: Deterministic AA wallet | ||
description: Propose a non-custodial interface for service providers to provide AA accounts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Propose a non-custodial interface for service providers to provide AA accounts. | |
description: Non-custodial interface for service providers to provide AA accounts. |
Cut out a bit of fluff, but I think you should expand on who "service providers" are, and what "provide" means in this context.
|
||
## Abstract | ||
|
||
Propose a non-custodial interface for service providers to provide AA accounts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just your description again. Your abstract should contain enough detail to give the reader a high-level (but still technical) overview of how your proposal accomplishes its goal.
- Problem | ||
- The `createAccount` function necessitates an `owner` address to establish an account, consequently preventing service providers from creating accounts on behalf of their users without knowledge of the users’ EOA addresses. To resolve this limitation, service providers employ temporary EOAs to deterministically generate an [ERC-4337](./eip-4337.md) account for their users, assigning the temporary EOA as the initial owner. This approach, however, introduces a security vulnerability, as the temporary EOAs’ private keys are managed by the service providers. Furthermore, the service providers assume responsibility for these private keys until such a time when users take the ownership. | ||
- Solution | ||
- Set a separate contract as the owner when calling `createAccount`, and allow the user to claim ownership at a later date via a signature provided by the service provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The motivation section should be written (for the most part) in normal paragraph style.
|
||
## Reference Implementation | ||
|
||
See `https://github.com/deterministic-aa/monorepo` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this external link. You may place a reference implementation inline (if it's CC0), or in the assets directory (if it's large or under another non-copyleft license.)
|
||
## Security Considerations | ||
|
||
Needs discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs discussion. | |
Needs discussion. <!-- TODO --> |
If you use an HTML-style comment, the linter will make sure you replace it before advancing statuses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a slight preference for SVGs, if you can provide them.
We propose a non-custodial interface for service providers to provide AA accounts.