New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC: Structured Data Clear Signing Format #509

Open

lcastillo-ledger wants to merge 25 commits into ethereum:master from lcastillo-ledger:master

lcastillo-ledger commented Jun 26, 2024

This is Ledger's proposal for a format enabling smartcontract developers to define the intended UI on wallets when signing a transaction or an EIP 712 message intended for the contract.

For more context, you can refer to this video: https://www.youtube.com/watch?v=-O7aX6vUvs8


          Clear Signing format request for comments

d96c4ab

lcastillo-ledger requested a review from eip-review-bot as a code owner

June 26, 2024 09:36

github-actions bot added c-new s-draft t-interface labels

Collaborator

eip-review-bot commented Jun 26, 2024 •

edited

Loading

File `ERCS/erc-7730.md`

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

eip-review-bot added e-consensus e-review labels

eip-review-bot changed the title ~~Ledger's Clear Signing format request for comments~~ Add ERC: Structured Data Clear Signing Format

github-actions bot added the w-ci label

abcoathup reviewed

View reviewed changes

ERCS/erc-xxx.md Outdated Show resolved Hide resolved

abcoathup reviewed

View reviewed changes

ERCS/erc-xxx.md Outdated Show resolved Hide resolved


          Assigning proposed EIP number

71543e2

abcoathup reviewed

View reviewed changes

ERCS/erc-7730.md Outdated Show resolved Hide resolved

abcoathup reviewed

View reviewed changes

ERCS/erc-7730.md Outdated Show resolved Hide resolved

abcoathup reviewed

View reviewed changes

ERCS/erc-7730.md Outdated Show resolved Hide resolved

lcastillo-ledger and others added 3 commits

June 28, 2024 09:28


          Update ERCS/erc-7730.md

aa89672

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>


          Update ERCS/erc-7730.md

6f38308

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>


          Update ERCS/erc-7730.md

68a9b96

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

usame-algan reviewed

View reviewed changes

ERCS/erc-7730.md Outdated Show resolved Hide resolved

usame-algan reviewed

View reviewed changes

ERCS/erc-7730.md Outdated Show resolved Hide resolved

usame-algan reviewed

View reviewed changes

ERCS/erc-7730.md Outdated Show resolved Hide resolved

usame-algan reviewed

View reviewed changes

ERCS/erc-7730.md Show resolved Hide resolved

usame-algan reviewed

View reviewed changes

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

Contributor

usame-algan commented Jul 2, 2024

Is it in the scope of this EIP on how to handle off-chain data? e.g. some swap transactions merely contain a reference (orderId) to the actual data. So an intent that is purely based on the transaction data might not give the user enough information whereas if the dApp knew what to do with the orderId, more information like the amount or tokens involved in the swap could be displayed.

lcastillo-ledger and others added 3 commits

September 1, 2024 18:21


          Update ERCS/erc-7730.md

e893d52

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>


          Update ERCS/erc-7730.md

3a8ae2f

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>


          Update ERCS/erc-7730.md

988a214

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>

github-actions bot removed the w-ci label


          Update ERCS/erc-7730.md

1658a12

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>

lcastillo-ledger and others added 5 commits

September 1, 2024 18:21


          Update ERCS/erc-7730.md

a352ddc

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>


          Update ERCS/erc-7730.md

768b072

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>


          Update ERCS/erc-7730.md

fa111fe

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>


          Update ERCS/erc-7730.md

cce1aa6

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>


          Update ERCS/erc-7730.md

415b9ad

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>

github-actions bot added the w-ci label


          Update erc-7730.md

6726eb3

SamWilsn reviewed

View reviewed changes

Collaborator

SamWilsn left a comment

I fixed your preamble. Please take a look at the errors generated by eipw. They'll need to be fixed before merging.

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

ERCS/erc-7730.md Outdated Show resolved Hide resolved

lcastillo-ledger and others added 2 commits

September 15, 2024 17:41


          Merge branch 'ethereum:master' into master

86a0e1d


          Update to the specification for v1 release

0fd0068

github-actions bot added w-ci and removed w-ci labels

lcastillo-ledger added 5 commits

September 15, 2024 18:14


          Fixes to pass linter checks


          Fixes to pass linter checks

79416fb


          Fixes to pass linter checks

bc0462a


          Fixes to pass linter checks

3ea1004


          Fixes to pass linter checks

79263ed

github-actions bot added t-erc and removed t-interface w-ci labels


          Fixes to pass linter checks

c691eef

github-actions bot commented Sep 15, 2024

The commit c691eef (as a parent of 6d2c71c) contains errors.
Please inspect the Run Summary for details.

github-actions bot added the w-ci label


          Fix eip-7730 link

8ab34e5

github-actions bot removed the w-ci label

Author

lcastillo-ledger commented Sep 15, 2024

I updated to take all reviewers comments into account and pass the linter checks


          Merge branch 'master' into master

62078af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

usame-algan usame-algan left review comments

abcoathup abcoathup left review comments

SamWilsn SamWilsn left review comments

eip-review-bot Awaiting requested review from eip-review-bot eip-review-bot is a code owner

At least 0 approving reviews are required to merge this pull request.

Labels

c-new e-consensus e-review s-draft t-erc