This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
revert bug #4130
Assignees
Labels
Comments
|
I changed the filler https://github.com/ethereum/tests/tree/fix-revert-bug |
|
Now I hit this problem #4148 which prevents me from filling tests. |
pirapira
added a commit
that referenced
this issue
Jun 15, 2017
This addresses #4130 together with the corresponding change in the test.
Merged
pirapira
added a commit
to ethereum/tests
that referenced
this issue
Jun 16, 2017
pirapira
added a commit
to ethereum/tests
that referenced
this issue
Jun 16, 2017
pirapira
added a commit
that referenced
this issue
Jun 20, 2017
This addresses #4130 together with the corresponding change in the test.
pirapira
added a commit
that referenced
this issue
Jun 20, 2017
This addresses #4130 together with the corresponding change in the test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We discovered that cpp does wrong revert of the state in case of address collision.
The test is here (with wrong cpp results):
https://github.com/ethereum/tests/blob/cffb263d6c9075e1396e72d5d8febc21329b6600/BlockchainTests/GeneralStateTests/stRevertTest/RevertDepthCreateAddressCollision.json#L642-L665
The source for this test is here:
https://github.com/ethereum/tests/blob/develop/src/GeneralStateTestsFiller/stRevertTest/RevertDepthCreateAddressCollisionFiller.json#L188-L205
It appears to be that cpp won't restore the code of the original account after collision overwrite and then OOG revert. (case d0g0 - double oog). Python is failing the test.
The text was updated successfully, but these errors were encountered: