This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
move transaction verification checks to sealEngine #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
reviewed
Apr 11, 2017
libethashseal/Ethash.cpp
Outdated
| } | ||
|
|
||
| // Check gas cost is enough. | ||
| int64_t baseGasRequired = _t.baseGasRequired(evmSchedule(_env)); |
There was a problem hiding this comment.
This check is already here on line 161
There was a problem hiding this comment.
hm. let me check. there was an issue when we removed this check in the last PR
|
I have a lots of state tests errors. And please remove the commented out code. |
Codecov Report
@@ Coverage Diff @@
## develop #4039 +/- ##
===========================================
+ Coverage 65.63% 65.71% +0.07%
===========================================
Files 309 309
Lines 22722 22698 -24
===========================================
+ Hits 14914 14915 +1
+ Misses 7808 7783 -25
|
gumb0
reviewed
Apr 18, 2017
libethashseal/Ethash.cpp
Outdated
| u256 startGasUsed = _env.gasUsed(); | ||
| if (startGasUsed + (bigint)_t.gas() > _env.gasLimit()) | ||
| { | ||
| //clog(ExecutiveWarnChannel) << "Cannot fit tx in block" << _env.number() << ": Require <" << (_env.gasLimit() - startGasUsed) << " Got" << _t.gas(); |
gumb0
approved these changes
Apr 18, 2017
|
EVMJIT build is failing now |
chfast
approved these changes
Apr 19, 2017
| u256 m_timestamp; | ||
| u256 m_difficulty; | ||
| int64_t m_gasLimit; | ||
| BlockHeader m_headerInfo; |
There was a problem hiding this comment.
I would just name it as m_header.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to #4038
refactor envInfo
split LastHashes and envInfo
next step is to replace envInfo with BlockHeader
updated test branch
ethereum/tests#151
@vbuterin
all of the state tests that used blockhash are now useless and should be migrated into blockchain tests.