This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
WIP - Download snapshot through Parity's warp protocol #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
changed the title
chriseth
reviewed
Jul 6, 2017
| m_latestHash = _r[3].toHash<h256>(); | ||
| m_genesisHash = _r[4].toHash<h256>(); | ||
| m_snapshotHash = _r[5].toHash<h256>(); | ||
| m_snapshotNumber = _r[6].toInt<u256>(); |
There was a problem hiding this comment.
What happens if the index goes "out of bounds"?
chriseth
reviewed
Jul 6, 2017
| disable("Invalid genesis hash"); | ||
| return false; | ||
| } | ||
| if (find(_protocolVersions.begin(), _protocolVersions.end(), m_protocolVersion) == _protocolVersions.end()) |
There was a problem hiding this comment.
I know it's a little less efficient on the average case, but _procotolVersions.count(m_protocolVersion) is much better readable and less error-prone.
Codecov Report
@@ Coverage Diff @@
## develop #4227 +/- ##
===========================================
- Coverage 69.78% 66.76% -3.03%
===========================================
Files 308 308
Lines 23345 23520 +175
===========================================
- Hits 16292 15703 -589
- Misses 7053 7817 +764
Continue to review full report at Codecov.
|
Merged
gumb0
force-pushed
the
snapshot-download
branch
from
534b663 to
504d6a8
Compare
gumb0
force-pushed
the
snapshot-download
branch
from
504d6a8 to
8f02fb9
Compare
5 tasks
|
Closing in favor of approach of #4622 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still in PoC-stage, downloads only from single peer, needs improvements in many minor details and tests.
It's better to start this pinning to one of Parity's boot nodes:
(other bootnodes for main net are here: https://github.com/paritytech/parity/blob/master/ethcore/res/ethereum/foundation.json#L182 )