This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Enable aleth-bootnode to connect to official Ethereum bootnodes #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5485 +/- ##
==========================================
- Coverage 61.87% 61.86% -0.01%
==========================================
Files 345 345
Lines 28690 28699 +9
Branches 3262 3265 +3
==========================================
+ Hits 17751 17756 +5
- Misses 9773 9781 +8
+ Partials 1166 1162 -4 |
chfast
reviewed
Feb 12, 2019
Looks like this test is flaky (I didn't touch any of this code so it's a test issue not a change issue):
I'll open a new issue for this |
chfast
suggested changes
Feb 13, 2019
Opened #5488 |
halfalicious
force-pushed
the
aleth-bootnode-bootstrap
branch
from
February 13, 2019 17:37
08da798
to
e929cc0
Compare
aleth-bootnode can now connect to the official Ethereum bootnode servers. I've also included a "--no-bootstrap" flag to disable this functionality at runtime.
Also rename function from pocHosts to defaultBootNodes
halfalicious
force-pushed
the
aleth-bootnode-bootstrap
branch
from
February 13, 2019 18:29
e929cc0
to
bad979f
Compare
Rebased |
gumb0
reviewed
Feb 13, 2019
chfast
reviewed
Feb 14, 2019
@@ -253,5 +253,24 @@ boost::log::formatting_ostream& operator<<(boost::log::formatting_ostream& _log, | |||
return _log << _node.id << '@' << _node.endpoint; | |||
} | |||
|
|||
unordered_map<Public, string>& defaultBootNodes() | |||
{ | |||
static unordered_map<Public, string> ret = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, does it have to be a map at all? I think an std::array
would work.
chfast
approved these changes
Feb 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable aleth-bootnode to connect to the official Ethereum bootnodes. This is now the behavior by default, but it can be disabled via the new "--no-boostrap" flag.
I've included this functionality because I think it's useful for discovery testing purposes. Additionally, it now enables one to run a discovery-only node that can participate on a public network without one having to manually bootstrap it with another Ethereum node.