-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5538 +/- ##
==========================================
+ Coverage 61.88% 61.91% +0.02%
==========================================
Files 344 344
Lines 28769 28757 -12
Branches 3269 3267 -2
==========================================
+ Hits 17805 17806 +1
+ Misses 9795 9783 -12
+ Partials 1169 1168 -1 |
Can you please update your PR description to mention the issue that you're fixing (and please be sure to include a "#" before the issue ID so that the issue is automatically updated with a link to this PR)? |
Can you also please remove the definition for Lines 378 to 384 in 4f638b0
Also please replace the check for enableDiscovery here with a check for !disableDiscovery : Line 926 in 4f638b0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just some minor changes
removed BadPrivateOption from enum AlethErrors as --private option has been removed from aleth
@@ -756,7 +736,7 @@ int main(int argc, char** argv) | |||
}; | |||
|
|||
auto netPrefs = publicIP.empty() ? NetworkConfig(listenIP, listenPort, upnp) : NetworkConfig(publicIP, listenIP ,listenPort, upnp); | |||
netPrefs.discovery = (privateChain.empty() && !disableDiscovery) || enableDiscovery; | |||
netPrefs.discovery = !disableDiscovery; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do the options for enable/disable discovery look like now?
PR 5538 removed the --private option from aleth
PR 5538 removed the --private option from aleth
Issue Name: Remove --private option from aleth #5531
--private option from aleth has been removed.