Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Don't sync with peer unless we already received Status message from it #5562

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Apr 11, 2019

Fixes #5556

@gumb0 gumb0 force-pushed the fix-premature-sync branch from de29b44 to e48c206 Compare April 11, 2019 10:53
@gumb0 gumb0 requested review from chfast and halfalicious April 11, 2019 12:13
@codecov-io
Copy link

Codecov Report

Merging #5562 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5562      +/-   ##
==========================================
+ Coverage   62.14%   62.14%   +<.01%     
==========================================
  Files         347      347              
  Lines       28979    28982       +3     
  Branches     3283     3284       +1     
==========================================
+ Hits        18009    18011       +2     
  Misses       9794     9794              
- Partials     1176     1177       +1

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test possible?

@gumb0 gumb0 merged commit e8c03b3 into master Apr 11, 2019
@gumb0 gumb0 deleted the fix-premature-sync branch April 11, 2019 13:44
@gumb0
Copy link
Member Author

gumb0 commented Apr 11, 2019

@chfast Not really, as this is in BlockChainSync clas

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants