This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Optimize NodeTable::nearestNodeEntries #5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5586 +/- ##
=========================================
- Coverage 62.22% 62.2% -0.03%
=========================================
Files 347 347
Lines 29136 29137 +1
Branches 3295 3295
=========================================
- Hits 18131 18124 -7
- Misses 9827 9832 +5
- Partials 1178 1181 +3 |
|
Needs rebase |
gumb0
force-pushed
the
optimize-nearestnodes
branch
from
60aa856 to
82e3a59
Compare
|
Rebased. |
halfalicious
reviewed
May 4, 2019
| @@ -112,7 +112,14 @@ class NodeTable : UDPSocketEvents | |||
| bool _enabled = true, bool _allowLocalDiscovery = false); | |||
|
|
|||
| /// Returns distance based on xor metric two node ids. Used by NodeEntry and NodeTable. | |||
There was a problem hiding this comment.
(Nit) Returns distance based on xor metric OF two node ids
chfast
approved these changes
May 4, 2019
halfalicious
approved these changes
May 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of calculating hash many times in the loop.
Make
distancefunction get hashes as input. Calculate hash for eachNodeEntryonly once and save it as a member ofNodeEntry.