This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
fix testeth --help output #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about and ? |
|
Also please add a changelog item |
Codecov Report
@@ Coverage Diff @@
## master #5627 +/- ##
=========================================
+ Coverage 62.59% 62.6% +0.01%
=========================================
Files 350 350
Lines 29690 29690
Branches 3344 3344
=========================================
+ Hits 18584 18587 +3
+ Misses 9897 9895 -2
+ Partials 1209 1208 -1 |
chfast
reviewed
Jun 17, 2019
test/tools/libtesteth/Options.cpp
Outdated
| cout << setw(35) << "--singlenet <networkId>" << setw(25) << "Run tests for a specific network (Frontier|Homestead|EIP150|EIP158|Byzantium|Constantinople|ConstantinopleFix)\n"; | ||
| cout << setw(35) << "--verbosity <level>" << setw(25) << "Set logs verbosity. 0 - silent, 1 - only errors, 2 - informative, >2 - detailed\n"; | ||
| cout << setw(35) << "--vm <name|path> (=legacy)" << setw(25) << "Set VM type for VMTests suite. Available options are: interpreter, legacy.\n"; | ||
| cout << setw(35) << "--evmc <option>=<value>" << setw(0) << "EVMC option\n"; |
There was a problem hiding this comment.
I don't believe you need setw(0) because the width is reset after every use.
gumb0
approved these changes
Jun 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #5627 +/- ##
=========================================
+ Coverage 62.59% 62.6% +0.01%
=========================================
Files 350 350
Lines 29690 29690
Branches 3344 3344
=========================================
+ Hits 18584 18587 +3
+ Misses 9897 9895 -2
+ Partials 1209 1208 -1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #5626