This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Handle import failures in test_importRawBlock #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
importrawblock-failure
branch
from
fbac83d to
75cc789
Compare
Codecov Report
@@ Coverage Diff @@
## master #5647 +/- ##
==========================================
+ Coverage 62.74% 62.78% +0.04%
==========================================
Files 348 348
Lines 29689 29709 +20
Branches 3345 3346 +1
==========================================
+ Hits 18627 18654 +27
+ Misses 9846 9841 -5
+ Partials 1216 1214 -2 |
gumb0
commented
Jul 3, 2019
| @@ -729,7 +729,33 @@ BOOST_AUTO_TEST_CASE(test_importRawBlock) | |||
| Json::Value ret; | |||
| Json::Reader().parse(c_genesisConfigString, ret); | |||
| rpcClient->test_setChainParams(ret); | |||
|
|
|||
| string blockHash = rpcClient->test_importRawBlock( | |||
There was a problem hiding this comment.
This test actually failed to import the block (difficulty was wrong in that block after changing difficulty rules for NoProof), but test_importRawBlock didn't report it.
There was a problem hiding this comment.
difficulty rules are still checked for NoProof.
nonce and mixHash are not checked.
There was a problem hiding this comment.
difficulty rules are still checked for NoProof.
that's the reason why this test worked incorrectly (block was invalid, I guess you created it when there were no difficulty check in NoProof yet)
I changed it now to have correct difficulty.
gumb0
force-pushed
the
importrawblock-failure
branch
from
f9092c7 to
0473839
Compare
chfast
approved these changes
Jul 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5646