This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Coming to agreement with geth on RIPEMD touch revert - alternative solution #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
untouch-ripemd-alternative
branch
2 times, most recently
from
c879b50 to
dd42631
Compare
Codecov Report
@@ Coverage Diff @@
## master #5663 +/- ##
==========================================
+ Coverage 63% 63.03% +0.02%
==========================================
Files 350 350
Lines 29905 29910 +5
Branches 3350 3351 +1
==========================================
+ Hits 18843 18854 +11
+ Misses 9846 9842 -4
+ Partials 1216 1214 -2 |
gumb0
force-pushed
the
untouch-ripemd-alternative
branch
from
dd42631 to
8665d20
Compare
…ree with geth. Now precompile stays touch even after revert in the calling frame, but only for one RIPEMD precompile.
gumb0
force-pushed
the
untouch-ripemd-alternative
branch
from
8665d20 to
e5b92d8
Compare
This was referenced Jul 10, 2019
|
Closing in favor of #5664 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to #5652