Implement EIP-2200: Structured Definitions for Net Gas Metering in LegacyVM #5709

gumb0 · 2019-07-31T16:30:25Z

I refactored SSTORE pricing unit tests a bit, to make them more table-driven.

codecov-io · 2019-07-31T16:48:33Z

Codecov Report

❗ No coverage uploaded for pull request base (master@f57fa86). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5709   +/-   ##
=========================================
  Coverage          ?   63.76%           
=========================================
  Files             ?      358           
  Lines             ?    30556           
  Branches          ?     3405           
=========================================
  Hits              ?    19483           
  Misses            ?     9844           
  Partials          ?     1229

gumb0 · 2019-09-03T12:57:49Z

Rebased.

halfalicious · 2019-09-05T02:49:02Z

You're getting an internal compiler error on the gcc config for some reason:

[195/251] Building CXX object aleth/CMakeFiles/aleth.dir/main.cpp.o
FAILED: aleth/CMakeFiles/aleth.dir/main.cpp.o 
/usr/bin/ccache /usr/bin/g++-6  -DETH_FATDB -I/home/builder/project -I/home/builder/project/aleth/../utils -isystem /home/builder/.hunter/_Base/c022f0c/0fe0970/6d1bd54/Install/include -I. -isystem deps/include -I/home/builder/project/evmc/include -O2 -g -fPIE   -fstack-protector-strong -Wall -Wextra -Werror -Wno-unknown-pragmas -fvisibility=hidden -g --coverage -std=c++11 -MD -MT aleth/CMakeFiles/aleth.dir/main.cpp.o -MF aleth/CMakeFiles/aleth.dir/main.cpp.o.d -o aleth/CMakeFiles/aleth.dir/main.cpp.o -c /home/builder/project/aleth/main.cpp
g++-6: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
[196/251] Building CXX object test/CMakeFiles/testeth.dir/tools/libtesteth/ImportTest.cpp.o
[197/251] Building CXX object test/CMakeFiles/testeth.dir/tools/libtesteth/boostTest.cpp.o
ninja: build stopped: subcommand failed.
Exited with code 1

chfast · 2019-09-05T08:50:24Z

You're getting an internal compiler error on the gcc config for some reason:

Not enough memory. Try to lower the number of parallel builds.

gumb0 · 2019-09-05T14:07:52Z

@chfast @halfalicious lowered BUILD_PARALLEL_JOBS to 2, now it passes

halfalicious · 2019-09-06T04:15:23Z

libethcore/EVMSchedule.h

@@ -156,6 +158,9 @@ static const EVMSchedule IstanbulSchedule = [] {
    schedule.extcodehashGas = 700;
    schedule.haveChainID = true;
    schedule.haveSelfbalance = true;
+    schedule.eip1283Mode = true;


Do we still need this var? eip1283 was rejected from Istanbul in favor of eip2200: https://eips.ethereum.org/EIPS/eip-1679

Can we control both the sstore and sload net gas metering via eip2200Mode?

Well it's basically the same rules...
(These two EIPs differ only in some price constants and in additional "throw below 2300 gas" rule)

But yeah, I think it would make sense to have eip1283Mode = true only in Constantinople, and then I'll change sstoreNetGasMetering() to return true for both eip1283Mode and eip2200Mode

halfalicious · 2019-09-06T05:06:59Z

libevm/LegacyVM.cpp

@@ -97,10 +97,13 @@ void LegacyVM::adjustStack(unsigned _removed, unsigned _added)

 void LegacyVM::updateSSGas()
 {
+    if (m_schedule->sstoreThrowsIfGasBelowCallStipend() && m_io_gas <= m_schedule->callStipend)


Why do we only throw OOG if EIP2200 is enabled, I'd expect us to always throw OOG if we don't have enough gas to cover the call stipend?

This rule is introduced only in EIP-2200.
(without it we normally throw in case of OOG from the updateIOGas call here

aleth/libevm/LegacyVM.cpp

Line 1678 in 0faec9d

updateIOGas();

)

Also express gas cost calculations of SSTORE setting to original value closer to how EIP specifies them.

Rework SSTORE unit tests to make them more table-driven.

gumb0 · 2019-09-23T15:49:17Z

Rebased.

gumb0 added the in progress label Jul 31, 2019

gumb0 added this to the Istanbul milestone Jul 31, 2019

gumb0 force-pushed the eip-2200 branch from b9eab1e to ab788cb Compare August 6, 2019 14:27

gumb0 mentioned this pull request Aug 7, 2019

[META] Istanbul implementation #5716

Closed

18 tasks

gumb0 removed the in progress label Aug 19, 2019

gumb0 force-pushed the eip-2200 branch 2 times, most recently from 2e8eeca to 34dd540 Compare August 26, 2019 10:37

gumb0 force-pushed the eip-2200 branch from 34dd540 to af317b1 Compare September 2, 2019 09:33

gumb0 requested review from chfast and halfalicious September 2, 2019 09:44

gumb0 force-pushed the eip-2200 branch from af317b1 to 06ec9fe Compare September 3, 2019 12:57

gumb0 force-pushed the eip-2200 branch from 06ec9fe to b692f9a Compare September 3, 2019 12:59

halfalicious reviewed Sep 6, 2019

View reviewed changes

gumb0 force-pushed the eip-2200 branch 2 times, most recently from 988c8cf to 0c4aaaf Compare September 23, 2019 10:54

gumb0 changed the title ~~Implement EIP-2200: Rebalance net-metered SSTORE gas cost with consideration of SLOAD gas cost change in LegacyVM~~ Implement EIP-2200: Structured Definitions for Net Gas Metering in LegacyVM Sep 23, 2019

gumb0 added 7 commits September 23, 2019 17:48

EIP-2200 Rebalance net-metered SSTORE gas cost

13159bf

Also express gas cost calculations of SSTORE setting to original value closer to how EIP specifies them.

EIP-2200: throw if gas goes below call stipend after SSTORE

3772fee

Unit tests for new prices of SSTORE gas metering accoring to EIP-2200

ea33067

Rework SSTORE unit tests to make them more table-driven.

Move "gas below stipend" check to the beginning of SSTORE instruction

3a83dd3

Unit test for calling SSTORE with gas below stipend

6d0fcd7

Add changelog item

5111bfa

Enable eip1283Mode only in EVMSchedule for Constantinople

604b44b

gumb0 force-pushed the eip-2200 branch from 0c4aaaf to 604b44b Compare September 23, 2019 15:48

gumb0 mentioned this pull request Sep 24, 2019

Implement EIP-2200: Structured Definitions for Net Gas Metering in aleth-interpreter #5728

Merged

chfast approved these changes Sep 24, 2019

View reviewed changes

gumb0 merged commit 0f41bb1 into master Sep 24, 2019

gumb0 deleted the eip-2200 branch September 24, 2019 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement EIP-2200: Structured Definitions for Net Gas Metering in LegacyVM #5709

Implement EIP-2200: Structured Definitions for Net Gas Metering in LegacyVM #5709

gumb0 commented Jul 31, 2019 •

edited

Loading

codecov-io commented Jul 31, 2019 •

edited

Loading

gumb0 commented Sep 3, 2019

halfalicious commented Sep 5, 2019

chfast commented Sep 5, 2019

gumb0 commented Sep 5, 2019

halfalicious Sep 6, 2019

gumb0 Sep 6, 2019

gumb0 Sep 6, 2019

halfalicious Sep 6, 2019

gumb0 Sep 6, 2019

gumb0 commented Sep 23, 2019

Implement EIP-2200: Structured Definitions for Net Gas Metering in LegacyVM #5709

Implement EIP-2200: Structured Definitions for Net Gas Metering in LegacyVM #5709

Conversation

gumb0 commented Jul 31, 2019 • edited Loading

codecov-io commented Jul 31, 2019 • edited Loading

Codecov Report

gumb0 commented Sep 3, 2019

halfalicious commented Sep 5, 2019

chfast commented Sep 5, 2019

gumb0 commented Sep 5, 2019

halfalicious Sep 6, 2019

Choose a reason for hiding this comment

gumb0 Sep 6, 2019

Choose a reason for hiding this comment

gumb0 Sep 6, 2019

Choose a reason for hiding this comment

halfalicious Sep 6, 2019

Choose a reason for hiding this comment

gumb0 Sep 6, 2019

Choose a reason for hiding this comment

gumb0 commented Sep 23, 2019

gumb0 commented Jul 31, 2019 •

edited

Loading

codecov-io commented Jul 31, 2019 •

edited

Loading