Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Upgrade Hunter to 0.23.211 to enable use of Visual Studio 2017 #5719

Merged
merged 3 commits into from
Aug 19, 2019
Merged

Upgrade Hunter to 0.23.211 to enable use of Visual Studio 2017 #5719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41883d5
Upgrade Hunter to enable Visual Studio 2017
halfalicious Aug 18, 2019
e53b0ad
Update README with info about VS 2017 support
halfalicious Aug 19, 2019
339a0fd
Update changelog
halfalicious Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
- Changed: [#5678](https://github.com/ethereum/aleth/pull/5678) Enable optimizer in aleth-interpreter by default.
- Changed: [#5675](https://github.com/ethereum/aleth/pull/5675) Disconnect from peer when syncing is disabled for peer.
- Changed: [#5676](https://github.com/ethereum/aleth/pull/5676) When receiving large batches of new block hashes, process up to 1024 hashes instead of disabling the peer.
- Changed: [#5719](https://github.com/ethereum/aleth/pull/5719) Enable support for Visual Studio 2017 on Windows.
- Removed: [#5631](https://github.com/ethereum/aleth/pull/5631) Removed PARANOID build option.
- Fixed: [#5562](https://github.com/ethereum/aleth/pull/5562) Don't send header request messages to peers that haven't sent us Status yet.
- Fixed: [#5581](https://github.com/ethereum/aleth/pull/5581) Fixed finding neighbour nodes in Discovery.
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ option(HUNTER_RUN_UPLOAD "Upload binaries to the cache server" ${run_upload})

include(HunterGate)
HunterGate(
URL "https://github.com/ruslo/hunter/archive/v0.23.178.tar.gz"
SHA1 "3511e5f2382d43cfa92b7f2a6f316fbdd1b81a92"
URL "https://github.com/ruslo/hunter/archive/v0.23.211.tar.gz"
SHA1 "c022f0c2480e835a6bafdd734035ec2071b51897"
LOCAL
)

Expand Down
7 changes: 3 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,13 @@ cmake .. # Configure the project.
cmake --build . # Build all default targets.
```

On **Windows** Visual Studio 2015 is required. You should generate Visual Studio
solution file (.sln) for 64-bit architecture by adding
`-G "Visual Studio 14 2015 Win64"` argument to the CMake configure command.
On **Windows** we support up to Visual Studio 2017. You should generate a Visual Studio solution file (.sln) for the 64-bit architecture by adding
`-G "Visual Studio 15 2017 Win64"` argument to the CMake configuration command.
After configuration is completed, the `aleth.sln` can be found in the
`build` directory.

```shell
cmake .. -G "Visual Studio 14 2015 Win64"
cmake .. -G "Visual Studio 15 2017 Win64"
```
#### Common Issues Building on Windows
##### LINK : fatal error LNK1158: cannot run 'rc.exe'
Expand Down