Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Pull Istanbul consensus tests and support postStateHash field in new tests #5755

Merged
merged 3 commits into from
Sep 25, 2019

Conversation

winsvega
Copy link
Contributor

requires Istanbul EIPs merged to regenerate the BlockchainTests

@winsvega winsvega requested a review from gumb0 September 23, 2019 13:49
@gumb0
Copy link
Member

gumb0 commented Sep 23, 2019

Update the tests repo submodule here
(chainid, sload+selfbalance are all merged, but EIP-2200 isn't yet, and as it probably affects all tests, I expect them to fail currently)

@gumb0 gumb0 added this to the Istanbul milestone Sep 24, 2019
@gumb0
Copy link
Member

gumb0 commented Sep 24, 2019

Also add a changelog item here

@gumb0 gumb0 mentioned this pull request Sep 24, 2019
@gumb0 gumb0 changed the title use postStateHash in new tests Pull Istanbul consensus tests and support postStateHash field in new tests Sep 24, 2019
@gumb0
Copy link
Member

gumb0 commented Sep 24, 2019

linux-clang6 build still requires #5728 to be merged

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #5755 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5755      +/-   ##
==========================================
- Coverage   63.78%   63.78%   -0.01%     
==========================================
  Files         358      358              
  Lines       30564    30571       +7     
  Branches     3405     3405              
==========================================
+ Hits        19496    19499       +3     
  Misses       9842     9842              
- Partials     1226     1230       +4

Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready now

@winsvega winsvega merged commit 32a5c98 into master Sep 25, 2019
@gumb0 gumb0 deleted the poststatehash branch September 25, 2019 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants