Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Optimize SELFDESTRUCT opcode in LegacyVM #5807

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Conversation

halfalicious
Copy link
Contributor

Check if transaction has enough gas to fund base gas cost for SELFDESTRUCT opcode before checking Ethereum state

@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@57b8156). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5807   +/-   ##
=========================================
  Coverage          ?   64.06%           
=========================================
  Files             ?      359           
  Lines             ?    30783           
  Branches          ?     3418           
=========================================
  Hits              ?    19720           
  Misses            ?     9837           
  Partials          ?     1226

@halfalicious halfalicious force-pushed the selfdestruct-legacyvm branch from 008b37b to d294fc2 Compare November 4, 2019 16:21
@halfalicious halfalicious force-pushed the selfdestruct-legacyvm branch from d294fc2 to 37a0524 Compare November 5, 2019 04:08
Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need rebase in changelog, please keep Added-Changed-Removed-Fixed order

@halfalicious halfalicious force-pushed the selfdestruct-legacyvm branch from 37a0524 to a1c2b91 Compare November 5, 2019 17:05
@halfalicious halfalicious merged commit 0a311f1 into master Nov 5, 2019
@halfalicious halfalicious deleted the selfdestruct-legacyvm branch November 5, 2019 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants