Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Return from RPC methods original transaction v value #5811

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Return from RPC methods original transaction v value #5811

merged 2 commits into from
Nov 8, 2019

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Nov 7, 2019

Fixes the problem mentioned in #4999 (comment)

cc @winsvega

@gumb0 gumb0 requested review from chfast and halfalicious November 7, 2019 18:39
@halfalicious
Copy link
Contributor

Looks like a new intermittent test failure (I've seen this before in one of my PRs but the test passed on re-run):

"737/768 Test #740: JsonRpcSuite/jsonrpc_setMining ........................................................................................***Failed    0.32 sec
Running tests using path: "/Users/distiller/project/test/jsontests"
Assertion failed: (h), function syncBlockQueue, file /Users/distiller/project/libethereum/Client.cpp, line 383.
Running 1 test case...
Test Case "jsonrpc_setMining": 
unknown location:0: fatal error: in "JsonRpcSuite/jsonrpc_setMining": signal: SIGABRT (application abort requested)
/Users/distiller/project/test/unittests/libweb3jsonrpc/jsonrpc.cpp:242: last checkpoint: "jsonrpc_setMining" fixture dtor

*** 1 failure is detected (6 failures are expected) in the test module "Master Test Suite"

@gumb0 gumb0 merged commit 39ee616 into master Nov 8, 2019
@gumb0 gumb0 deleted the rpc-v branch November 8, 2019 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants