Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Revert "wait for 2 seconds on disconnect" changes #5841

Merged
merged 5 commits into from
Nov 22, 2019
Merged

Conversation

halfalicious
Copy link
Contributor

Changes were causing frequent exceptions during syncing (see #5835, #5828) due to Host::m_sessions and EthereumPeer::m_peers getting out-of-sync (if a peer reconnects during a pending disconnect), so we are reverting the changes in the 1.7 release until we can properly address the sync issues.

@halfalicious halfalicious requested review from gumb0 and chfast November 22, 2019 04:33
@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #5841 into release/1.7 will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.7    #5841      +/-   ##
===============================================
+ Coverage         63.8%   63.81%   +0.01%     
===============================================
  Files              358      358              
  Lines            30595    30598       +3     
  Branches          3406     3406              
===============================================
+ Hits             19520    19525       +5     
- Misses            9846     9847       +1     
+ Partials          1229     1226       -3

@gumb0
Copy link
Member

gumb0 commented Nov 22, 2019

I think we shouldn't modify 1.7.0 changelog, as it's already released, so I added an entry about revert to 1.7.2 instead

@gumb0 gumb0 merged commit dfb76ed into release/1.7 Nov 22, 2019
@gumb0 gumb0 deleted the revert-disconnect branch November 22, 2019 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants