Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

testeth treat nullrlp as invalid #5893

Merged
merged 3 commits into from
Mar 2, 2020
Merged

testeth treat nullrlp as invalid #5893

merged 3 commits into from
Mar 2, 2020

Conversation

winsvega
Copy link
Contributor

@winsvega winsvega commented Feb 22, 2020

fetch tests with this PR
ethereum/tests#614

includes this PR:
#5891

@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #5893 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5893      +/-   ##
==========================================
+ Coverage   63.95%   63.99%   +0.04%     
==========================================
  Files         365      365              
  Lines       31095    31097       +2     
  Branches     3441     3442       +1     
==========================================
+ Hits        19887    19902      +15     
+ Misses       9976     9964      -12     
+ Partials     1232     1231       -1

Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also could you add a changelog saying "RLP tests treat empty RLP encoding as error."

update blockchain tests to geth+retesteth
@gumb0 gumb0 merged commit 2cc5937 into master Mar 2, 2020
@gumb0 gumb0 deleted the nullrlp branch March 2, 2020 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants