Use ERC-55 mixed-case checksum address encoding for execution address #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philknows
approved these changes
Dec 22, 2023
dapplion
previously approved these changes
Jan 8, 2024
nflaig
force-pushed
the
eip-55-execution-address
branch
3 times, most recently
from
1848005 to
32e035e
Compare
nflaig
force-pushed
the
eip-55-execution-address
branch
from
32e035e to
f2b493f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #395 it would be good if we could use ERC-55 mixed-case checksum address encoding for execution addresses in beacon API spec.
If this gets merged we should also do the same to keymanager API spec (types/eth_address.yaml#L2). Builder API spec references SignedValidatorRegistration from beacon API spec so we should be fine there (some example values could be updated)