Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to latest openapi #409

Merged
merged 2 commits into from
Jan 15, 2024
Merged

chore: upgrade to latest openapi #409

merged 2 commits into from
Jan 15, 2024

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Jan 12, 2024

Starting with OpenAPI 3.1 description can be overridden at the $ref level.

Migrating to this stable version allows to fix an incorrect usage of allOf attempting to overcome the previous limitation.

with openapi 3.0

type: object
properties:
 root:
  allOf:
   - $ref: '../../../beacon-node-oapi.yaml#/components/schemas/Root'
   - description: HashTreeRoot of BeaconState object

with openapi 3.1

type: object
properties:
 root:
    $ref: '../../../beacon-node-oapi.yaml#/components/schemas/Root'
    description: HashTreeRoot of BeaconState object

The migration to openapi 3.1 is fairly smooth and only involves replacing the now deprecated nullable attribute with null type

required by #407

Copy link
Collaborator

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone rolfyone merged commit 0d2aa4c into ethereum:master Jan 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants